Differential D8695

Fix ampersand characters not showing in tab titles
AbandonedPublic
Actions

Authored by davidedmundson on Nov 7 2017, 3:14 PM.

Details

Reviewers
corentinr
Summary

QT tabs don't display ampersand normally as they are used as shortcuts (http://doc.qt.io/qt-4.8/qtabwidget.html#addTab). This was issued here : https://bugs.kde.org/show_bug.cgi?id=382512.
Pressing alt would enable to use the letter following the ampersand as a shortcut. If a user use this character in a tab title he might be confused not to see it displayed

By doubling the ampersands in the tab titles, the issue is fixed (at the cost of not being able to make shortcut when we understand the QT system)

Diff Detail

Repository
R106 KSysguard
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
corentinr created this revision.Nov 7 2017, 3:14 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 7 2017, 3:14 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
adridg added a subscriber: adridg.Nov 7 2017, 3:21 PM
adridg added inline comments.
gui/Workspace.cpp
142

Are you sure this won't affect tabs that *do* have shortcuts, and need them? How about after a save/restart cycle, are the ampersands re-doubled?

corentinr edited the summary of this revision. (Show Details)Nov 7 2017, 3:36 PM
corentinr added inline comments.Nov 7 2017, 3:46 PM
gui/Workspace.cpp
142

There is no default tab with shortcut and I felt there was no need for them. If the Qt shortcut feature is preferable the best way would probably be a tooltip upon entering an ampersand in the title.

save/restart cycle doesn't re-doubled as this replace is"on the fly" and never saved anywhere.

ngraham added a subscriber: ngraham.Feb 6 2018, 12:05 AM

Hello! I'm very sorry that this patch was somehow missed and not committed in back November, and that another patch with the same diff took its place yesterday. This was an oversight on our part and we will try to make sure that it doesn't happen again!

davidedmundson commandeered this revision.Nov 29 2018, 2:01 PM
davidedmundson added a reviewer: corentinr.
davidedmundson added a subscriber: davidedmundson.

This appears to be merged. I'm going to close it.

davidedmundson abandoned this revision.Nov 29 2018, 2:01 PM

Revision Contents
Changeset List

PathPackages
Mgui/Workspace.cpp (6 lines)

Diff 22032

View Options

gui/Workspace.cpp

Loading...