Differential D8684

text improvements for Colors, Icons, Style, and Workspace KCMs
ClosedPublic
Actions

Authored by ngraham on Nov 6 2017, 7:50 PM.

Details

Reviewers
abetts
apol
Group Reviewers
VDG
Plasma
Documentation
Commits
R119:df78989bb287: text improvements for Colors, Icons, Style, and Workspace KCMs
Summary

BUG: 386570
BUG: 386565
BUG: 386575
BUG: 386567

Implement some of @abetts' proposals in the above-mentioned bugs

Test Plan

Tested in KDE Neon:

Diff Detail

Repository
R119 Plasma Desktop
Branch
arcpatch-D8684
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Nov 6 2017, 7:50 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 6 2017, 7:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham edited the test plan for this revision. (Show Details)Nov 6 2017, 7:51 PM
ngraham updated this revision to Diff 21998.Nov 6 2017, 8:31 PM

Colors KCM text improvements

ngraham retitled this revision from Style KCM text improvements to Style and Colors KCM text improvements.Nov 6 2017, 8:32 PM
ngraham edited the summary of this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)
ngraham updated this revision to Diff 21999.Nov 6 2017, 8:33 PM

Fix unnecessary whitespace change

ngraham retitled this revision from Style and Colors KCM text improvements to text improvements for Style, Colors, and Workspace KCMs.Nov 6 2017, 10:14 PM
ngraham edited the summary of this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)
ngraham updated this revision to Diff 22006.Nov 6 2017, 10:15 PM

Also update Workspace KCM strings

ngraham updated this revision to Diff 22007.Nov 6 2017, 10:16 PM

hover -> mouse hover

ngraham edited the test plan for this revision. (Show Details)Nov 6 2017, 10:19 PM
ngraham updated this revision to Diff 22009.Nov 6 2017, 10:50 PM

Also address 386567; better text for the "enable icon animation" checkbox

ngraham retitled this revision from text improvements for Style, Colors, and Workspace KCMs to text improvements for Colors, Icons, Style, and Workspace KCMs.Nov 6 2017, 10:52 PM
ngraham edited the summary of this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)
apol accepted this revision.Nov 7 2017, 12:33 AM
apol added a subscriber: apol.

Looks good!

This revision is now accepted and ready to land.Nov 7 2017, 12:33 AM
abetts added a comment.Nov 7 2017, 2:34 AM

Just on the first image

"Inactive selection changes color"

to

"Change colors for inactive selection"

Just to make sure that the checkbox starts with a verb.

ngraham updated this revision to Diff 22015.Nov 7 2017, 3:02 AM
ngraham edited the test plan for this revision. (Show Details)

Better text for inactive selection checkbox

ngraham edited the test plan for this revision. (Show Details)Nov 7 2017, 3:02 AM
lueck added a subscriber: lueck.Nov 7 2017, 6:14 AM
lueck added inline comments.
doc/kcontrol/colors/index.docbook
17–18 ↗(On Diff #21999)

Please bump date + releasinfo

doc/kcontrol/icons/index.docbook
18–19 ↗(On Diff #22015)

Please bump date + releasinfo

doc/kcontrol/kcmstyle/index.docbook
17–18 ↗(On Diff #21999)

Please bump date + releasinfo

ngraham updated this revision to Diff 22027.Nov 7 2017, 1:50 PM

Update dobcook dates and release versions

ngraham marked 3 inline comments as done.Nov 7 2017, 1:51 PM
abetts accepted this revision.Nov 8 2017, 3:06 AM
Closed by commit R119:df78989bb287: text improvements for Colors, Icons, Style, and Workspace KCMs (authored by ngraham). · Explain WhyNov 8 2017, 3:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 22006

View Options

doc/kcontrol/colors/index.docbook

Loading...
View Options

doc/kcontrol/kcmstyle/index.docbook

Loading...
View Options

kcms/colors/scmeditoroptions.ui

Loading...
View Options

kcms/style/finetuning.ui

Loading...
View Options

kcms/workspaceoptions/mainpage.ui

Loading...