BUG: 386571
BUG: 386574
BUG: 386576
Implemented some of @abetts' string change and UI suggestions in the above bugs.
Details
Details
- Reviewers
abetts davidedmundson apol graesslin - Group Reviewers
VDG KWin - Commits
- R108:819230d49550: Improve some strings and UI elements in KWin KCM
Tested in KDE Neon:
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| scripts/minimizeall/metadata.desktop | ||
|---|---|---|
| 42 | This is not what the script does. The weird description that exists is weird, but correct ("un-minimize all windows that were minimized by the script" or something like this) | |
| scripts/minimizeall/metadata.desktop | ||
|---|---|---|
| 42 | I know, but does it really matter? Is the distinction between windows that were minimized by the script vs windows that the user manually minimized important enough to make this description longer and more awkward? | |
Comment Actions
Can we at least find something more legible? I don't care if it is my suggestion or not, just something more approachable and readable.
| scripts/minimizeall/metadata.desktop | ||
|---|---|---|
| 42 | No idea, maybe ask the torch bearing crowd that cried for this feature because there once was a secret key to make desktop showing behave this way... (yes, the exact behavior was crucial ...) iow: as long as Martin can always reply with "because translators are idiots, but the feature itself didn't change" I frankly don't care whether there's a description at all. | |
Comment Actions
Please be aware that this will cause work for translators and they might be puzzled because their translated string will just be the same. If a native speaker thinks that the new texts are better than I'm fine with this. But if it is just a minor improvement or no real improvement at all I always decided against such changes to not cause unnecessary work for the translators.
That said: as I'm not a native speaker and thus I won't give an accept for this change. If a native speaker accepts it, I'm fine with it. David's accept of course does not hold any more as the review changed afterwards.
| scripts/minimizeall/metadata.desktop | ||
|---|---|---|
| 42 | I think the distinction is important. Otherwise we get bug reports about it. Yes, such things happen. | |
| 48 | Please don't adjust translations. That's handled by scripty automatically. | |
| 75 | Same here: don't update translations. | |
Comment Actions
Gotcha, thanks for the background. I will adjust the string to note the distinction and address the other inline comments. FWIW I am a native English speaker, and "...unminimize all such way minimized windows" is simply gramatically wrong, and needs to be changed regardless. How about "Adds a shortcut to minimize and un-minimize all windows (only affects windows minimized by this script)"
Comment Actions
Can you resign from the revision then so you're not leaving unresolved negative feedback?
Comment Actions
So what is the path forward here? Do I need more thumbs-up for the latest version from native English speakers?
Comment Actions
With my native speaker hat on:
Mostly fine.
| kcmkwin/kwinscreenedges/touch.ui | ||
|---|---|---|
| 36 | we've removed full stops from all independent sentences on the last KCM, but left this one. | |
| scripts/minimizeall/metadata.desktop | ||
| 42 | The word "restore" would probably simplify things. That implies "(only affects windows minimized by this script)" in fewer words. | |
Comment Actions
Remove "(only affects windows minimized by this script)", as it is implied by the word "restore"