Validate that for all attributes an itemData exists
AbandonedPublic

Authored by dhaumann on Nov 5 2017, 10:03 AM.

Details

Reviewers
vkrause
cullmann
Summary

This patch adds a check at compile time that verifies that for
all refereced attributes an itemData item must exist. If not,
a failure is raised, stopping the process of creating the Qt
resource file that contains the syntax highlighting files.

Test Plan

make

Diff Detail

Repository
R216 Syntax Highlighting
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
dhaumann created this revision.Nov 5 2017, 10:03 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 5 2017, 10:03 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript

This patch is not yet ready, since we still have the following errors:

  1. data/syntax/haml.xml" Reference of non-existing itemData attributes: QSet("Array", "Ruby embedded in haml", "Escaped Text")
  2. data/syntax/lilypond.xml" Reference of non-existing itemData attributes: QSet("Tremolo")
  3. data/syntax/metafont.xml" Reference of non-existing itemData attributes: QSet("Bullet", "Verbatim", "Tex")
  4. data/syntax/relaxng.xml" Reference of non-existing itemData attributes: QSet("Entity Reference")
  5. data/syntax/rhtml.xml" Reference of non-existing itemData attributes: QSet("RUBY RAILS ERB Text")
  6. data/syntax/rmarkdown.xml" Reference of non-existing itemData attributes: QSet("Markdown", "Document Headers")
  7. data/syntax/stata.xml" Reference of non-existing itemData attributes: QSet("String2")

Help to fix these is welcome.

dhaumann updated this revision to Diff 21900.Nov 5 2017, 10:08 AM
  • Fix typo
vkrause accepted this revision.Nov 10 2017, 10:25 AM
This revision is now accepted and ready to land.Nov 10 2017, 10:25 AM
dhaumann abandoned this revision.Dec 3 2017, 1:10 PM

Abandoned in favor of D9125.