Differential D8658

Change "Open..." to "Add Image..." in Wallpaper chooser
ClosedPublic
Actions

Authored by ngraham on Nov 4 2017, 8:29 PM.

Details

Reviewers
broulik
davidedmundson
Group Reviewers
Plasma
Commits
R120:1be6aecf248f: Change "Open..." to "Add Image..." in Wallpaper chooser
Summary

Changes the button in the wallpaper chooser marked "Open..." to say "Add Image..". This matches the text style for the button in slideshow mode, which says, "Add Folder"

Also added ellipses to "Add Folder"; it's now "Add Folder..."

Test Plan

Tested in KDE Neon.

Before:

After:

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Nov 4 2017, 8:29 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 4 2017, 8:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham edited the test plan for this revision. (Show Details)Nov 4 2017, 8:31 PM
ngraham added reviewers: Plasma, broulik.
aspotashev added a subscriber: aspotashev.Nov 4 2017, 8:32 PM
aspotashev added inline comments.
wallpapers/image/imagepackage/contents/ui/config.qml
392

The ellipsis ("Add Image...") is mandatory because the button opens a dialog.

Read in https://community.kde.org/KDE_Visual_Design_Group/HIG/Labels :
"End the label with an ellipsis if the command requires additional information to execute."

ngraham updated this revision to Diff 21882.Nov 4 2017, 8:33 PM

Restore elipses since this opens a file chooser dialog; also add elipses to the "Add Folder" button for the slideshow style

ngraham retitled this revision from Change "Open..." to "Add Image" in Wallpaper chooser to Change "Open..." to "Add Image..." in Wallpaper chooser.Nov 4 2017, 8:36 PM
ngraham edited the summary of this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)
ngraham marked an inline comment as done.
davidedmundson accepted this revision.Nov 4 2017, 9:44 PM
This revision is now accepted and ready to land.Nov 4 2017, 9:44 PM
Closed by commit R120:1be6aecf248f: Change "Open..." to "Add Image..." in Wallpaper chooser (authored by ngraham). · Explain WhyNov 5 2017, 2:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 21887

View Options

wallpapers/image/imagepackage/contents/ui/config.qml

Loading...