Differential D8654

Don't ask for compiler-specific includes in QmlJS
ClosedPublic
Actions

Authored by aaronpuchert on Nov 4 2017, 6:38 PM.

Details

Reviewers

mwolff

Group Reviewers

KDevelop

Commits

R32:3512f8906466: Don't ask for compiler-specific includes in QmlJS

Summary

We can't provide these, since there is no QmlJS compiler.

The entire design is a bit problematic, because the QmlJS plugin asks
the DefinesAndIncludesManager for include directories, but that manager
is somehow tied to the idea of using the configured compiler to provide
additional includes and defines. However, the configured compiler is
obviously only used for C/C++ and similar languages, not QmlJS.

Diff Detail

Repository

R32 KDevelop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

aaronpuchert created this revision.Nov 4 2017, 6:38 PM

lgtm

This revision is now accepted and ready to land.Nov 6 2017, 12:27 PM

Technically, we need only D8653 or this change to fix bug 386388. Do we still want this change?

The changes in the DefinesAndIncludesManager make things certainly more consistent.

Imo this makes the code more consistent, as you say. So feel free to push it, too.

Closed by commit R32:3512f8906466: Don't ask for compiler-specific includes in QmlJS (authored by aaronpuchert). · Explain WhyNov 13 2017, 11:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			plugins/custom-definesandincludes/definesandincludesmanager.h (6 lines)
M			plugins/custom-definesandincludes/definesandincludesmanager.cpp (27 lines)
M			plugins/custom-definesandincludes/idefinesandincludesmanager.h (12 lines)
M			plugins/qmljs/qmljsparsejob.cpp (7 lines)