Add separator between special mime types and mime type list
ClosedPublic

Authored by broulik on Nov 2 2017, 4:30 PM.

Details

Reviewers
dfaure
Summary

Makes it clearer that the top are convenience groups whereas the rest of the list is individual types.
Also actually make use of the outdated SPECIAL_TYPES define.

Test Plan

Verified that searching for 3gp files (the first in the list) and translation template (last in the list) and all audio still works.

Ideally, we used the combobox' data() feature to store the mime name and/or special key and not rely on list indices but that's a story for another time.

Diff Detail

Repository
R228 KFind
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Nov 2 2017, 4:30 PM
dfaure accepted this revision.Nov 15 2017, 8:01 AM
dfaure added inline comments.
src/kftabdlg.cpp
56

static const int, while you're at it ;)

This revision is now accepted and ready to land.Nov 15 2017, 8:01 AM
broulik closed this revision.Nov 27 2017, 10:23 AM

Was committed as part of D8623