Differential D8618

[Folder View] Emit dataChanged for CheckStateRole only
ClosedPublic
Actions

Authored by broulik on Nov 2 2017, 1:26 PM.

Details

Reviewers
hein
davidedmundson
Group Reviewers
Plasma
Commits
R119:c08d28a08c1d: [Folder View] Emit dataChanged for CheckStateRole only
Summary

We only change that role in setCheckedPlugins

Test Plan

Opened preview settings dialog, everything was still checked properly upon opening the dialog
Mime types in filter were still properly checked, Check All still worked

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Nov 2 2017, 1:26 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 2 2017, 1:26 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Nov 2 2017, 1:28 PM
This revision is now accepted and ready to land.Nov 2 2017, 1:28 PM
broulik updated this revision to Diff 21770.Nov 2 2017, 1:28 PM
broulik edited the test plan for this revision. (Show Details)
  • Do the same for mime types model
Closed by commit R119:c08d28a08c1d: [Folder View] Emit dataChanged for CheckStateRole only (authored by broulik). · Explain WhyNov 2 2017, 1:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 21771

View Options

containments/desktop/plugins/folder/mimetypesmodel.cpp

Loading...
View Options

containments/desktop/plugins/folder/previewpluginsmodel.cpp

Loading...