Kicker: Use QtLoggingRules
ClosedPublic
Actions

Authored by davidedmundson on Nov 2 2017, 12:07 AM.

Details

Reviewers

apol
hein

Group Reviewers

Plasma

Commits

R119:5a892dc88e25: Kicker: Use QtLoggingRules
R120:83ef0d4d596c: Kicker: Use QtLoggingRules

Summary

And get rid of the non-standard DEBUG macro with formatting included
If a dev wants a QT_MESSAGE_PATTERN they should set one themselves, otherwise it conflicts.

Test Plan

compiles

Diff Detail

Repository

R119 Plasma Desktop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson created this revision.Nov 2 2017, 12:07 AM

Restricted Application added a project: Plasma. · View Herald TranscriptNov 2 2017, 12:07 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

davidedmundson edited the summary of this revision. (Show Details)Nov 2 2017, 12:34 AM

apol accepted this revision.Nov 2 2017, 12:37 AM

This revision is now accepted and ready to land.Nov 2 2017, 12:37 AM

hein accepted this revision.Nov 2 2017, 8:58 AM

Closed by commit R119:5a892dc88e25: Kicker: Use QtLoggingRules (authored by davidedmundson). · Explain WhyNov 2 2017, 12:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			applets/kicker/CMakeLists.txt (5 lines)
M			applets/kicker/plugin/kastatsfavoritesmodel.cpp (62 lines)
M			applets/kicker/plugin/placeholdermodel.cpp (6 lines)