Differential D8601

Avoid blocking DBus calls when extracting files
ClosedPublic
Actions

Authored by davidedmundson on Nov 1 2017, 5:26 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R119:b3044152a31c: Avoid blocking DBus calls when extracting files
Summary

When copying from Ark to the desktop we make a blocking DBus call,
freezing the entire UI until the extraction completes.

We don't do anything with the reply, so lets not bother waiting for it.

Test Plan

Ran Q_DBUS_BLOCKING_CALL_MAIN_THREAD_WARNING_MS=0 plasmashell
Copied something from ark to the desktop.
Still had the file, but didn't block

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Nov 1 2017, 5:26 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 1 2017, 5:26 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Nov 1 2017, 5:39 PM
This revision is now accepted and ready to land.Nov 1 2017, 5:39 PM
Closed by commit R119:b3044152a31c: Avoid blocking DBus calls when extracting files (authored by davidedmundson). · Explain WhyNov 1 2017, 5:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 21722

View Options

containments/desktop/plugins/folder/foldermodel.cpp

Loading...