Details
Diff Detail
- Repository
- R67 KDevelop Execute Browser
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
executebrowserplugin.cpp | ||
---|---|---|
87 | Looks like something will be missing now, at least it won't be very backwards compatible. For "https://kde.org/index.html" the host used to be "kde.org", now you are assuming that the schema is part of the host? Should we change the serverEntry definition to be the base url rather than the hostname? |
I have replied to @apol but I don't know how to submit the coment. I have 1 unsubmitted comment, but no way to submit it :(
executebrowserplugin.cpp | ||
---|---|---|
87 | Yes, that was something odd with the old code. It added manually a fixed scheme part with url.setScheme("http"); so i guess you could not use https:// for your project. Now, I assume the schema part is part of the host. Maybe we could change the label in the .ui I wonder if with the old code you could open a url like "https://kde.org/index.html", I bet that you could''t. |
you did fine ;)
executebrowserplugin.cpp | ||
---|---|---|
87 | Probably not. Now if we need to go this way, it would probably make sense to use a different configuration setting, otherwise people will get weird URLs. |
executebrowserplugin.cpp | ||
---|---|---|
87 | What about if( !host.contains(QStringLiteral("://")) ) { host.prepend(QStringLiteral("http://")); } |
@santilin
I would like to merge it, including schema defaulting to http:// as I have proposed,
any objections?