Folder View icons properties: Improve visual layout
ClosedPublic

Authored by marten on Oct 31 2017, 8:07 AM.

Details

Summary

This change is similar to D8424, for the "Icons" tab of the dialogue. In the current layout:

the controls are all of varying sizes and are not aligned, and the group titles are indented so far that they are not immediately recognisable as such.

The revised layout:

uses a single grid layout to enforce the sizes and alignment of the GUI controls.

Note that the screen shots above have had the QML tweaked to show all of the controls, in order to demonstrate the entire layout. In practice (and in the diff here of course) not all of the controls are shown depending on the containment type of the folder view.

Test Plan

Built plasma-desktop with this change. Checked appearance and operation of the configuration dialogue both as a desktop containment and as a standalone plasmoid.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
marten created this revision.Oct 31 2017, 8:07 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 31 2017, 8:07 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
marten updated this revision to Diff 21601.Oct 31 2017, 8:14 AM

Minor comment fix

hein accepted this revision.Nov 1 2017, 9:18 AM
hein added a subscriber: hein.

Lovely, again thanks so much for tackling this, it's long overdue.

This revision is now accepted and ready to land.Nov 1 2017, 9:18 AM
This revision was automatically updated to reflect the committed changes.