Add Bundle information for OSX
ClosedPublic

Authored by laysrodrigues on Oct 30 2017, 3:35 PM.

Details

Summary

Signed-off-by: Lays Rodrigues <lays.silva@tvglobo.com.br>

Diff Detail

Repository
R232 AtCore
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
laysrodrigues created this revision.Oct 30 2017, 3:35 PM
rizzitello requested changes to this revision.Oct 30 2017, 3:39 PM
rizzitello added inline comments.
testclient/CMakeLists.txt
45

the above else is only run if (APPLE) please put this in that else. (line 34).

Will test on mac os as soon as I get a chance.

This revision now requires changes to proceed.Oct 30 2017, 3:39 PM
tcanabrava added inline comments.Oct 30 2017, 4:48 PM
testclient/CMakeLists.txt
45

why in the else? it seems right to me.

rizzitello added inline comments.Oct 30 2017, 4:55 PM
testclient/CMakeLists.txt
45

We would have if done as commited.

line 22 :  if (NOT APPLE) 
   options for almost all builds..
line 34: else () 
   Apple specific options. 
line 38: end if () 
line 39: if (APPLE) 
      more apple specific stuff
line 46: endif()

See the second if is not needed and its contens should go in the previous else since that is already equilvent to if(APPLE)

laysrodrigues marked an inline comment as done.

Fix location of bundle information code as sith
pointed out

Fix order of entries

Last fix invert order of install and add_executable

Remove empty line

rizzitello requested changes to this revision.Oct 31 2017, 12:24 PM
rizzitello added inline comments.
testclient/CMakeLists.txt
44

This line is still here ?

This revision now requires changes to proceed.Oct 31 2017, 12:24 PM

Remove extra line

rizzitello accepted this revision.Oct 31 2017, 4:20 PM

πŸ‘ Great!

This revision is now accepted and ready to land.Oct 31 2017, 4:20 PM
This revision was automatically updated to reflect the committed changes.