Needed e.g. for boarding pass rendering in D8395.
Details
Details
- Reviewers
svuorela dfaure - Group Reviewers
Frameworks - Commits
- R280:2e2664b0ab0a: Add Aztec code generator
Diff Detail
Diff Detail
- Repository
- R280 Prison
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Thanks for this contribution. I think it is good and needed.
| autotests/CMakeLists.txt | ||
|---|---|---|
| 2 | I'd like an extra level of directories given the large amount of test files, so we have e.g. autotests/aztec/ with the relevant files and helpers. | |
| autotests/aztec-compact-data-0011.png | ||
| 1 ↗ | (On Diff #21526) | For all these images, are this the only valid encoding for the relevant data, or are there enough extra data in aztec codes that a valid set of data can be encoded in multiple ways ? |
| autotests/aztec-compact-data-0011.png | ||
|---|---|---|
| 1 ↗ | (On Diff #21526) | There are two kinds of test images here, those that test just the rendering code and those that test the full encoding too. The first ones are not valid codes but are unique. The latter are valid but unfortunately all but unique. There's multiple valid ways to encode input text into the bit stream, and you can select how much error correction you want to have. |
Comment Actions
Fix off-by-one inconsistency in layerCount
It now always means the amount of layers and not the index of the last layer. Fixes rendering of the unusually short Air Baltic boarding pass data.
Comment Actions
I like it. Though I haven't fully reviewed the bit magic and actually tested it, but the first can be fixed at a later point, and the latter I trust you on.
| autotests/aztec-compact-data-0011.png | ||
|---|---|---|
| 1 ↗ | (On Diff #21526) | Can we mark those that tests the full encoding that are valid but not unique (so that we know which ones should be updated if we change something in e.g. the error correction, and then need external validation before updating the images) |
Comment Actions
Separate test images into those containing only rendering/layouting data and those with full data encoding.