Make MyMoneyFile header less dependent
AbandonedPublic

Authored by wojnilowicz on Oct 28 2017, 9:27 AM.

Details

Summary

The goal of this patch is to reduce dependability on mymoneyfile and of mymoneyfile on other libraries.
Changes:

  1. no header file includes mymoneyfile now,
  2. mymoneyfile.h uses forward-declarations instead of includes.

Patch is huge but it's nothing but code shuffling. Nonetheless it has two important merits i.e. smaller executable file and shorter compilation times.

Diff Detail

Repository
R261 KMyMoney
Lint
Lint Skipped
Unit
Unit Tests Skipped
wojnilowicz created this revision.Oct 28 2017, 9:27 AM

I have not tested it at all, but it looks clean and OK to me. It makes maintenance of the 4.8 branch a bit harder though.

I have not tested it at all, but it looks clean and OK to me. It makes maintenance of the 4.8 branch a bit harder though.

Thanks for reviewing. It's true what you say but how long could we maintain 4.8 branch. It's 16 months since its release.
I do more serious work on encapsulation of mymoney library now and found (no fixes now) some misuses which could result in crashes or other bugs. So in the end it gives us something good.

wojnilowicz abandoned this revision.Oct 30 2017, 5:58 PM