Differential D8529

Plasma change icons should exit after its work finished.
ClosedPublic
Actions

Authored by xuetianweng on Oct 27 2017, 10:51 PM.

Details

Reviewers
apol
mart
broulik
Group Reviewers
Plasma
Commits
R119:60bc30083fe4: Plasma change icons should exit after its work finished.
Summary

Right now plasma-iconchanges may remains on the system after change the icon
theme.

Test Plan

Run plasma-changeicons manually. It does exit and change the icon theme.

Diff Detail

Repository
R119 Plasma Desktop
Branch
Plasma/5.11
Lint
No Linters Available
Unit
No Unit Test Coverage
xuetianweng created this revision.Oct 27 2017, 10:51 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 27 2017, 10:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added a comment.Oct 30 2017, 2:36 PM

hmm, i feel it would be more correct to connect to the procedure finished and then quit the app?

xuetianweng added a comment.Oct 30 2017, 2:40 PM

@mart I understand what you want to say, but for this specific case:

https://lxr.kde.org/source/frameworks/kio/src/widgets/kbuildsycocaprogressdialog.cpp#0037

rebuildKSycoca invokes dialog.exec() so it returns after the rebuild is done.

And thus there's no signal that can be used for this function.

broulik added a subscriber: broulik.Jan 4 2018, 4:09 PM

Good to go, no?

xuetianweng added a comment.Jan 5 2018, 12:38 AM
In D8529#186000, @broulik wrote:

Good to go, no?

I have no problem with that. Any one have extra comment?

broulik accepted this revision.Jan 5 2018, 9:08 AM
This revision is now accepted and ready to land.Jan 5 2018, 9:08 AM
Closed by commit R119:60bc30083fe4: Plasma change icons should exit after its work finished. (authored by xuetianweng). · Explain WhyJan 6 2018, 5:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/icons/changeicons.cpp (2 lines)

Diff 21457

View Options

kcms/icons/changeicons.cpp

Loading...