Details

Reviewers

Group Reviewers

Commits

R94:a7ca3d97ec91: Add support for text/pgp.

Summary

If Someone sends an encrypted attachment without any content, we should
display the content of the encrypted attachment.

Test Plan

show one text/pgp encrypted attachment correctly (included as testdata).

Also make sure, that a "fake" text/pgp attachment don't break the viewer.
This part is not working at the moment, I'll look at it later...

Diff Detail

Repository

R94 PIM: Message Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

knauss created this revision.Oct 27 2017, 1:31 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 27 2017, 1:31 PM

Restricted Application added a subscriber: KDE PIM. · View Herald Transcript

knauss added reviewers: KDE PIM, vkrause.Oct 27 2017, 1:32 PM

with this patch solving https://bugs.kde.org/324365 should become reachable.

Add a wrongly marked as text/PGP part.

Add a wrongly marked as text/PGP part

Treat wrongly as text/pgp marked mimepart as attachment.

fix content encoding ( pgp is normally everything as utf-8)

Closed by commit R94:a7ca3d97ec91: Add support for text/pgp. (authored by knauss). · Explain WhyOct 29 2017, 4:43 PM

This revision was automatically updated to reflect the committed changes.

		Path
A	M	mimetreeparser/autotests/data/headeronly/openpgp-encrypted-no-text-attachment-non-encrypted.mbox.html (10 lines)
A	M	mimetreeparser/autotests/data/hidden/openpgp-encrypted-no-text-attachment-non-encrypted.mbox.html (10 lines)
A	M	mimetreeparser/autotests/data/inlined/openpgp-encrypted-no-text-attachment-non-encrypted.mbox.html (17 lines)
A	M	mimetreeparser/autotests/data/openpgp-encrypted-no-text-attachment-non-encrypted.mbox (26 lines)
A	M	mimetreeparser/autotests/data/openpgp-encrypted-no-text-attachment-non-encrypted.mbox.html (19 lines)
A	M	mimetreeparser/autotests/data/openpgp-encrypted-no-text-attachment-non-encrypted.mbox.tree (4 lines)
A	M	mimetreeparser/autotests/data/openpgp-encrypted-no-text-attachment.mbox (32 lines)
A	M	mimetreeparser/autotests/data/openpgp-encrypted-no-text-attachment.mbox.html (37 lines)
A	M	mimetreeparser/autotests/data/openpgp-encrypted-no-text-attachment.mbox.tree (5 lines)
M		mimetreeparser/src/CMakeLists.txt (1 line)
A	M	mimetreeparser/src/bodyformatter/encrypted.h (36 lines)
A	M	mimetreeparser/src/bodyformatter/encrypted.cpp (105 lines)
M		mimetreeparser/src/bodypartformatter.cpp (2 lines)
M		mimetreeparser/src/messagepart.h (2 lines)
M		mimetreeparser/src/messagepart.cpp (20 lines)
M		mimetreeparser/src/nodehelper.h (2 lines)
M		mimetreeparser/src/nodehelper.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	21433	6d47dc1		Oct 27 2017, 1:31 PM	★	★
Diff 2	21522	6d47dc1	Add a wrongly marked as text/PGP part.	Oct 29 2017, 2:21 PM	★	★
Diff 3	21523	6d47dc1	Add a wrongly marked as text/PGP part	Oct 29 2017, 2:26 PM	★	★
Diff 4	21524	6d47dc1	Treat wrongly as text/pgp marked mimepart as attachment.	Oct 29 2017, 3:01 PM	★	★
Diff 5	21527	6d47dc1	- fix content encoding ( pgp is normally everything as utf-8)	Oct 29 2017, 3:28 PM	★	★
Diff 6	21529	4596224	R94:a7ca3d97ec919a74a1521547efae8042e1928e5f	Oct 29 2017, 4:43 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
9534dc4618cc	ae49b1e26ba4	c6ed42420783	Sandro Knauß	fix content encoding ( pgp is normally everything as utf-8)	Oct 29 2017, 3:28 PM
c6ed42420783	63c85395a887	2a7ec8ae4f46	Sandro Knauß	Add a wrongly marked as text/PGP part	Oct 29 2017, 2:25 PM
2a7ec8ae4f46	f560e2d45e40	6d47dc109c38	Sandro Knauß	Add support for text/pgp. (Show More…)	Oct 27 2017, 1:22 PM

Add support for text/pgp.
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 21529

mimetreeparser/autotests/data/headeronly/openpgp-encrypted-no-text-attachment-non-encrypted.mbox.html

mimetreeparser/autotests/data/hidden/openpgp-encrypted-no-text-attachment-non-encrypted.mbox.html

mimetreeparser/autotests/data/inlined/openpgp-encrypted-no-text-attachment-non-encrypted.mbox.html

mimetreeparser/autotests/data/openpgp-encrypted-no-text-attachment-non-encrypted.mbox

mimetreeparser/autotests/data/openpgp-encrypted-no-text-attachment-non-encrypted.mbox.html

mimetreeparser/autotests/data/openpgp-encrypted-no-text-attachment-non-encrypted.mbox.tree

mimetreeparser/autotests/data/openpgp-encrypted-no-text-attachment.mbox

mimetreeparser/autotests/data/openpgp-encrypted-no-text-attachment.mbox.html

mimetreeparser/autotests/data/openpgp-encrypted-no-text-attachment.mbox.tree

mimetreeparser/src/CMakeLists.txt

mimetreeparser/src/bodyformatter/encrypted.h

mimetreeparser/src/bodyformatter/encrypted.cpp

mimetreeparser/src/bodypartformatter.cpp

mimetreeparser/src/messagepart.h

mimetreeparser/src/messagepart.cpp

mimetreeparser/src/nodehelper.h

mimetreeparser/src/nodehelper.cpp

Add support for text/pgp.ClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 21529

mimetreeparser/autotests/data/headeronly/openpgp-encrypted-no-text-attachment-non-encrypted.mbox.html

mimetreeparser/autotests/data/hidden/openpgp-encrypted-no-text-attachment-non-encrypted.mbox.html

mimetreeparser/autotests/data/inlined/openpgp-encrypted-no-text-attachment-non-encrypted.mbox.html

mimetreeparser/autotests/data/openpgp-encrypted-no-text-attachment-non-encrypted.mbox

mimetreeparser/autotests/data/openpgp-encrypted-no-text-attachment-non-encrypted.mbox.html

mimetreeparser/autotests/data/openpgp-encrypted-no-text-attachment-non-encrypted.mbox.tree

mimetreeparser/autotests/data/openpgp-encrypted-no-text-attachment.mbox

mimetreeparser/autotests/data/openpgp-encrypted-no-text-attachment.mbox.html

mimetreeparser/autotests/data/openpgp-encrypted-no-text-attachment.mbox.tree

mimetreeparser/src/CMakeLists.txt

mimetreeparser/src/bodyformatter/encrypted.h

mimetreeparser/src/bodyformatter/encrypted.cpp

mimetreeparser/src/bodypartformatter.cpp

mimetreeparser/src/messagepart.h

mimetreeparser/src/messagepart.cpp

mimetreeparser/src/nodehelper.h

mimetreeparser/src/nodehelper.cpp

Add support for text/pgp.
ClosedPublic
Actions

Revision Contents
Changeset List