Differential D8520

Set CXX min version to C++11, fix of warnings
ClosedPublic
Actions

Authored by Kanedias on Oct 27 2017, 12:50 PM.

Details

Reviewers

hein

Commits

R7:1d591297fd3d: Set CXX min version to C++11, fix of warnings

Summary

Set CXX min version to C++11, fix of warnings

- Add `override` to virtual functions where needed
- Add `static` to functions wthout definition
- Replace `0` with `nullptr` where needed

Test Plan

Just cleaned up code, no changes yet

Diff Detail

Repository

R7 Konversation

Branch

wip/qtquick-c++11

Lint

Lint OK

Unit

No Unit Test Coverage

Kanedias created this revision.Oct 27 2017, 12:50 PM

This is nice, but it would be great to fix the other 20% of warnings it causes, too, otherwise it's a noisy build that hides more important warnings :)

In D8520#160857, @hein wrote:

This is nice, but it would be great to fix the other 20% of warnings it causes, too, otherwise it's a noisy build that hides more important warnings :)

Will do, though some issues with old phonon headers will remain...

I just wanted to make sure CMake & C++ std version bump is OK for us :)

Add out-of-tree translation unit for KonviSettingsPage
Remove redundant copy-constructor for ConnectionSettings
Fix rest of warnings

Phew... that was interesting dive.
I guess this is now ready for review, @hein

In case you see other warnings I may have missed, please let me know.

Kanedias retitled this revision from Set CXX min version to C++11, fix ~80% of warnings to Set CXX min version to C++11, fix of warnings.Oct 29 2017, 7:42 AM

apol added a subscriber: apol.Oct 30 2017, 7:07 PM

apol added inline comments.

src/config/preferences.cpp
379	Make const.
src/config/warnings_config.cpp
209	warningDialogDefinitions should be const. Use either qAsConst or make const.
src/dbus.cpp
242	const
src/dcc/chat.cpp
421	Why do you need this if you have a default?
434	Why do you need this if you have a default?
src/dcc/chatcontainer.cpp
134	Why do you need this if you have a default?
src/sound.cpp
41	weird new line.
src/statusbar.cpp
67	Weird new line
src/unicode.cpp
58	Why do you need this if you have a default?
src/viewer/channeloptionsdialog.cpp
323	This looks wrong. Should it be QString::number()? Or just QVariant()? I may be wrong...
src/viewer/ignore.h
33	?
src/viewer/searchbar.cpp
123	const

Kanedias added inline comments.Oct 30 2017, 9:23 PM

src/dcc/chat.cpp
421	Clang complains about this an you asked to deal with all warnings so here it is :) The rationale behind this is if you want to extend enum then it will fall through to default case which is probably not what you want. With this check in place (-Wswitch-enum) it will warn you again if you missed one or more switches while extending enum. I can remove this if you want.
434	Replied above
src/dcc/chatcontainer.cpp
134	Replied above
src/sound.cpp
41	Fixed
src/statusbar.cpp
67	Fixed
src/unicode.cpp
58	Replied above
src/viewer/channeloptionsdialog.cpp
323	Well it was effectively the same in the old variant, i is QChar here... let me indicate this in a loop init to make it more clear.
src/viewer/ignore.h
33	Enums are implicitly 'int's, 1 << 31 is 0x80 00 00 00, 8 here sets highest possible bit of 'int' variable, which is a sign digit and it flips the sign. I figured out that we need just a big value for the Exception flag, so 30 would suffice.
src/viewer/searchbar.cpp
123	Done

Fixes for review comments

Kanedias added inline comments.Oct 30 2017, 9:29 PM

src/config/warnings_config.cpp
209	But it's const... It looks like `const struct {...} warningDialogDefinitions`. Compiler gives me "duplicate const" warning if I try to add one between `}` and its name

apol added inline comments.Oct 31 2017, 1:23 AM

src/dcc/chat.cpp
421	If there's no other cases, I'd suggest to drop the default. But then this is @hein's decision.

hein added inline comments.Nov 1 2017, 9:47 AM

src/dcc/chat.cpp
421	I'm OK-ish with exhaustive matching, maybe getting biased from Rust pattern matching ...
src/irc/server.cpp
3310	Why?
3324	Why?

Kanedias added inline comments.Nov 1 2017, 10:53 AM

src/irc/server.cpp
3310	Unreachable statements
3324	Here too, first condition always returns.

About those unreachable statements: Could you leave them in but comment them out? I have a feeling that was someone's poor attempt at leaving a TODO in ...

In D8520#162766, @hein wrote:

About those unreachable statements: Could you leave them in but comment them out? I have a feeling that was someone's poor attempt at leaving a TODO in ...

Sure, will update when I'm home.

Returned unreachable statements, commented out

Please put into wip/qtquick :)

This revision is now accepted and ready to land.Nov 2 2017, 8:55 AM

FWIW, note there's Qt's Q_UNREACHABLE macro for this (which asserts when hit).

Kanedias closed this revision.Nov 2 2017, 5:42 PM

In D8520#163530, @apol wrote:

FWIW, note there's Qt's Q_UNREACHABLE macro for this (which asserts when hit).

Clang still complaints with it but thanks, will keep in mind!

Large Diff

This large diff affects 210 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (3 lines)
M		src/CMakeLists.txt (1 line)
M		src/application.h (4 lines)
M		src/application.cpp (56 lines)
M		src/awaymanager.h (4 lines)
M		src/awaymanager.cpp (4 lines)
M		src/bookmarkhandler.h (2 lines)
M		src/cipher.cpp (4 lines)
M		src/common.h (3 lines)
M		src/common.cpp (6 lines)
M		src/config/alias_config.h (4 lines)
M		src/config/alias_config.cpp (6 lines)
M		src/config/autoreplace_config.h (4 lines)
M		src/config/autoreplace_config.cpp (6 lines)
M		src/config/configdialog.h (4 lines)
M		src/config/configdialog.cpp (18 lines)
M		src/config/connectionbehavior_config.h (2 lines)
M		src/config/dcc_config.h (2 lines)
M		src/config/dcc_config.cpp (8 lines)
M		src/config/highlight_config.h (4 lines)
M		src/config/highlight_config.cpp (6 lines)
M		src/config/ignore_config.h (4 lines)
M		src/config/ignore_config.cpp (23 lines)
M		src/config/nicklistbehavior_config.h (4 lines)
M		src/config/nicklistbehavior_config.cpp (10 lines)
M		src/config/osd_config.h (6 lines)
M		src/config/preferences.h (2 lines)
M		src/config/preferences.cpp (6 lines)
M		src/config/quickbuttons_config.h (4 lines)
M		src/config/quickbuttons_config.cpp (8 lines)
M		src/config/settingsdialog.h (2 lines)
M		src/config/settingsdialog.cpp (6 lines)
M		src/config/settingspage.h (2 lines)
A	M	src/config/settingspage.cpp (17 lines)
M		src/config/tabs_config.h (4 lines)
M		src/config/tabs_config.cpp (4 lines)
M		src/config/theme_config.h (4 lines)
M		src/config/theme_config.cpp (14 lines)
M		src/config/warnings_config.h (4 lines)
M		src/config/warnings_config.cpp (13 lines)
M		src/connectionmanager.h (4 lines)
M		src/connectionmanager.cpp (10 lines)
M		src/dbus.h (4 lines)
M		src/dbus.cpp (6 lines)
M		src/dcc/chat.h (2 lines)
M		src/dcc/chat.cpp (24 lines)
M		src/dcc/chatcontainer.h (4 lines)
M		src/dcc/chatcontainer.cpp (12 lines)
M		src/dcc/dcccommon.h (6 lines)
M		src/dcc/dcccommon.cpp (6 lines)
M		src/dcc/recipientdialog.h (2 lines)
M		src/dcc/resumedialog.h (2 lines)
M		src/dcc/resumedialog.cpp (8 lines)
M		src/dcc/transfer.h (2 lines)
M		src/dcc/transfer.cpp (4 lines)
M		src/dcc/transferdetailedinfopanel.h (4 lines)
M		src/dcc/transferdetailedinfopanel.cpp (8 lines)
M		src/dcc/transferlistmodel.h (6 lines)
M		src/dcc/transferlistmodel.cpp (2 lines)
M		src/dcc/transfermanager.h (8 lines)
M		src/dcc/transfermanager.cpp (24 lines)
M		src/dcc/transferpanel.h (2 lines)
M		src/dcc/transferpanel.cpp (8 lines)
M		src/dcc/transferrecv.h (4 lines)
M		src/dcc/transferrecv.cpp (41 lines)
M		src/dcc/transfersend.h (2 lines)
M		src/dcc/transfersend.cpp (24 lines)
M		src/dcc/transferview.h (4 lines)
M		src/dcc/transferview.cpp (12 lines)
M		src/dcc/whiteboard.h (4 lines)
M		src/dcc/whiteboard.cpp (4 lines)
M		src/dcc/whiteboardcolorchooser.h (4 lines)
M		src/dcc/whiteboardcolorchooser.cpp (8 lines)
M		src/dcc/whiteboardfontchooser.h (2 lines)
M		src/dcc/whiteboardfontchooser.cpp (4 lines)
M		src/dcc/whiteboardpaintarea.h (4 lines)
M		src/dcc/whiteboardtoolbar.h (2 lines)
M		src/dcc/whiteboardtoolbar.cpp (28 lines)
M		src/guess_ja.cpp (2 lines)
M		src/identity.cpp (4 lines)
M		src/identitydialog.h (4 lines)
M		src/identitydialog.cpp (6 lines)
M		src/identitymodel.h (6 lines)
M		src/identitymodel.cpp (4 lines)
M		src/irc/channel.h (4 lines)
M		src/irc/channel.cpp (56 lines)
M		src/irc/channellistpanel.h (4 lines)
M		src/irc/channelnick.cpp (4 lines)
M		src/irc/inputfilter.h (2 lines)
M		src/irc/inputfilter.cpp (26 lines)
M		src/irc/invitedialog.cpp (2 lines)
M		src/irc/irccharsets.cpp (10 lines)
M		src/irc/ircqueue.h (5 lines)
M		src/irc/joinchanneldialog.h (4 lines)
M		src/irc/joinchanneldialog.cpp (4 lines)
M		src/irc/messagemodel.h (12 lines)
M		src/irc/messagemodel.cpp (8 lines)
M		src/irc/modebutton.h (2 lines)
M		src/irc/modebutton.cpp (4 lines)
M		src/irc/nick.h (2 lines)
M		src/irc/nick.cpp (4 lines)
M		src/irc/nickinfo.cpp (4 lines)
M		src/irc/nicklistview.h (2 lines)
M		src/irc/nicklistview.cpp (8 lines)
M		src/irc/nicksonline.h (2 lines)
M		src/irc/nicksonline.cpp (44 lines)
M		src/irc/outputfilter.h (6 lines)
M		src/irc/outputfilter.cpp (10 lines)
M		src/irc/outputfilterresolvejob.h (2 lines)
M		src/irc/outputfilterresolvejob.cpp (4 lines)
M		src/irc/query.h (2 lines)
M		src/irc/query.cpp (2 lines)
M		src/irc/server.h (6 lines)
M		src/irc/server.cpp (66 lines)
M		src/irc/servergroupdialog.h (12 lines)
M		src/irc/servergroupdialog.cpp (8 lines)
M		src/irc/serverlistdialog.h (4 lines)
M		src/irc/serverlistdialog.cpp (8 lines)
M		src/irc/serverlistview.h (2 lines)
M		src/irc/serverlistview.cpp (5 lines)
M		src/irc/serversettings.h (1 line)
M		src/irc/serversettings.cpp (9 lines)
M		src/irc/topichistorymodel.h (4 lines)
M		src/irc/topichistorymodel.cpp (8 lines)
M		src/irc/usermodel.h (24 lines)
M		src/irc/usermodel.cpp (12 lines)
M		src/konsolepanel.h (2 lines)
M		src/konsolepanel.cpp (8 lines)
M		src/mainwindow.h (2 lines)
M		src/mainwindow.cpp (16 lines)
M		src/notificationhandler.h (4 lines)
M		src/notificationhandler.cpp (4 lines)
M		src/qtquick/kpackage_packagestructure_konversation_uipackage/themestructure.cpp (4 lines)
M		src/queuetuner.h (2 lines)
M		src/queuetuner.cpp (10 lines)
M		src/quickconnectdialog.h (4 lines)
M		src/quickconnectdialog.cpp (4 lines)
M		src/scriptlauncher.h (2 lines)
M		src/scriptlauncher.cpp (4 lines)
M		src/sound.h (4 lines)
M		src/sound.cpp (3 lines)
M		src/statusbar.h (4 lines)
M		src/statusbar.cpp (8 lines)
M		src/unicode.cpp (4 lines)
M		src/upnp/upnpdescriptionparser.cpp (11 lines)
M		src/upnp/upnpmcastsocket.h (2 lines)
M		src/upnp/upnpmcastsocket.cpp (14 lines)
M		src/upnp/upnprouter.h (4 lines)
M		src/upnp/upnprouter.cpp (7 lines)
M		src/urlcatcher.h (8 lines)
M		src/urlcatcher.cpp (8 lines)
M		src/viewer/awaylabel.h (4 lines)
M		src/viewer/awaylabel.cpp (4 lines)
M		src/viewer/channeloptionsdialog.h (2 lines)
M		src/viewer/channeloptionsdialog.cpp (16 lines)
M		src/viewer/chatwindow.h (4 lines)
M		src/viewer/chatwindow.cpp (12 lines)
M		src/viewer/completer.h (6 lines)
M		src/viewer/completer.cpp (8 lines)
M		src/viewer/editnotifydialog.h (6 lines)
M		src/viewer/editnotifydialog.cpp (4 lines)
M		src/viewer/highlightviewitem.h (2 lines)
M		src/viewer/highlightviewitem.cpp (4 lines)
M		src/viewer/ignore.h (2 lines)
M		src/viewer/ignore.cpp (4 lines)
M		src/viewer/ignorelistviewitem.h (10 lines)
M		src/viewer/ignorelistviewitem.cpp (4 lines)
M		src/viewer/images.h (2 lines)
M		src/viewer/images.cpp (9 lines)
M		src/viewer/inputhistorymodel.h (12 lines)
M		src/viewer/inputhistorymodel.cpp (8 lines)
M		src/viewer/insertchardialog.h (4 lines)
M		src/viewer/insertchardialog.cpp (6 lines)
M		src/viewer/irccontextmenus.h (2 lines)
M		src/viewer/irccontextmenus.cpp (14 lines)
M		src/viewer/ircinput.h (2 lines)
M		src/viewer/ircinput.cpp (4 lines)
M		src/viewer/ircview.h (8 lines)
M		src/viewer/ircview.cpp (34 lines)
M		src/viewer/ircviewbox.h (2 lines)
M		src/viewer/logfilereader.h (2 lines)
M		src/viewer/logfilereader.cpp (6 lines)
M		src/viewer/osd.h (6 lines)
M		src/viewer/osd.cpp (5 lines)
M		src/viewer/pasteeditor.h (2 lines)
M		src/viewer/pasteeditor.cpp (2 lines)
M		src/viewer/qclipboardwrapper.h (4 lines)
M		src/viewer/qclipboardwrapper.cpp (4 lines)
M		src/viewer/quickbutton.h (2 lines)
M		src/viewer/quickbutton.cpp (4 lines)
M		src/viewer/rawlog.h (2 lines)
M		src/viewer/rawlog.cpp (4 lines)
M		src/viewer/searchbar.h (2 lines)
M		src/viewer/searchbar.cpp (16 lines)
M		src/viewer/statuspanel.h (2 lines)
M		src/viewer/statuspanel.cpp (6 lines)
M		src/viewer/topicedit.h (4 lines)
M		src/viewer/topicedit.cpp (10 lines)
M		src/viewer/topichistoryview.h (16 lines)
M		src/viewer/topichistoryview.cpp (18 lines)
M		src/viewer/topiclabel.h (4 lines)
M		src/viewer/topiclabel.cpp (6 lines)
M		src/viewer/trayicon.h (4 lines)
M		src/viewer/trayicon.cpp (4 lines)
M		src/viewer/viewcontainer.h (10 lines)
M		src/viewer/viewcontainer.cpp (118 lines)
M		src/viewer/viewspringloader.h (2 lines)
M		src/viewer/viewspringloader.cpp (12 lines)
M		src/viewer/viewtree.h (6 lines)
M		src/viewer/viewtree.cpp (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	21429			Oct 27 2017, 12:49 PM	★	★
Diff 2	21498			Oct 28 2017, 4:30 PM	★	★
Diff 3	21591	9eb1fc5	Fixes for review comments	Oct 30 2017, 9:25 PM	★	★
Diff 4	21734	9eb1fc5	Returned unreachable statements, commented out	Nov 1 2017, 9:27 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
528902af1781	df3c008db27a	9eb1fc5e3263	Oleg Chernovskiy	Set CXX min version to C++11, fix warnings (Show More…)	Oct 27 2017, 12:42 PM

Set CXX min version to C++11, fix of warningsClosedPublicActions

Details

Diff Detail

Large Diff

Revision ContentsChangeset List

Diff 21734

CMakeLists.txt

src/CMakeLists.txt

src/application.h

src/application.cpp

src/awaymanager.h

src/awaymanager.cpp

src/bookmarkhandler.h

src/cipher.cpp

src/common.h

src/common.cpp

src/config/alias_config.h

src/config/alias_config.cpp

src/config/autoreplace_config.h

src/config/autoreplace_config.cpp

src/config/configdialog.h

src/config/configdialog.cpp

src/config/connectionbehavior_config.h

src/config/dcc_config.h

src/config/dcc_config.cpp

src/config/highlight_config.h

src/config/highlight_config.cpp

src/config/ignore_config.h

src/config/ignore_config.cpp

src/config/nicklistbehavior_config.h

src/config/nicklistbehavior_config.cpp

src/config/osd_config.h

src/config/preferences.h

src/config/preferences.cpp

src/config/quickbuttons_config.h

src/config/quickbuttons_config.cpp

src/config/settingsdialog.h

src/config/settingsdialog.cpp

src/config/settingspage.h

src/config/settingspage.cpp

src/config/tabs_config.h

src/config/tabs_config.cpp

src/config/theme_config.h

src/config/theme_config.cpp

src/config/warnings_config.h

src/config/warnings_config.cpp

src/connectionmanager.h

src/connectionmanager.cpp

src/dbus.h

src/dbus.cpp

src/dcc/chat.h

src/dcc/chat.cpp

src/dcc/chatcontainer.h

src/dcc/chatcontainer.cpp

src/dcc/dcccommon.h

src/dcc/dcccommon.cpp

src/dcc/recipientdialog.h

src/dcc/resumedialog.h

src/dcc/resumedialog.cpp

src/dcc/transfer.h

src/dcc/transfer.cpp

src/dcc/transferdetailedinfopanel.h

src/dcc/transferdetailedinfopanel.cpp

src/dcc/transferlistmodel.h

src/dcc/transferlistmodel.cpp

src/dcc/transfermanager.h

src/dcc/transfermanager.cpp

src/dcc/transferpanel.h

src/dcc/transferpanel.cpp

src/dcc/transferrecv.h

src/dcc/transferrecv.cpp

src/dcc/transfersend.h

src/dcc/transfersend.cpp

src/dcc/transferview.h

src/dcc/transferview.cpp

src/dcc/whiteboard.h

src/dcc/whiteboard.cpp

src/dcc/whiteboardcolorchooser.h

src/dcc/whiteboardcolorchooser.cpp

src/dcc/whiteboardfontchooser.h

Set CXX min version to C++11, fix of warnings
ClosedPublic
Actions

Revision Contents
Changeset List