Improve initialization of properties in Report Designer
ClosedPublic

Authored by staniek on Oct 27 2017, 9:50 AM.

Details

Summary

Improve initialization of KReportSectionData and KReportDesigner, initially clear "modified" flags for properties.

Test Plan

Insert some elements in kreportexample or Kexi. Or open saved report in Kexi. Properties should not be marked as modified initially.

Also the recent KProperty API 3.0.91 allows for live updates of properties (for now only works for the line element) but it looks like a good start.

Diff Detail

Repository
R14 KReport
Branch
arcpatch-D8518
Lint
No Linters Available
Unit
No Unit Test Coverage
staniek created this revision.Oct 27 2017, 9:50 AM
Restricted Application added a project: KReport. · View Herald TranscriptOct 27 2017, 9:50 AM
staniek edited the test plan for this revision. (Show Details)Oct 27 2017, 9:52 AM
staniek retitled this revision from Improve initialization of KReportSectionData and KReportDesigner, initially clear "modified" flags for properties to Improve initialization of properties in Report Designer.Oct 27 2017, 9:54 AM
staniek edited the summary of this revision. (Show Details)
staniek edited the test plan for this revision. (Show Details)

This is initial patch. Trying to add more fixes like this.

staniek updated this revision to Diff 21432.EditedOct 27 2017, 1:16 PM
  • Add clearModifiedFlags() for more property sets on initialization (usually loading from XML)

This is how it looks now in Kexi. Notice how no properties are in bold anymore. The only exception is for the Position property for items (other than Line) - it got modified for unclear reason when are just clicked. Position is there slightly updated on click (but visually without effect since the grid is enabled).

@piggz Ready for review I think. Most of the code here is moved around so we can call clearModifiedFlags() unconditionally when we're done with initializing, no matter if we create new elements or load them from XML.

staniek updated this revision to Diff 21460.Oct 27 2017, 11:10 PM

Merge in master changes.

piggz accepted this revision.Oct 29 2017, 11:31 PM
This revision is now accepted and ready to land.Oct 29 2017, 11:31 PM
This revision was automatically updated to reflect the committed changes.