Differential D851

Port kded plugin to json metadata
ClosedPublic
Actions

Authored by heikobecker on Jan 21 2016, 6:25 PM.

Tags

None

Subscribers

Details

Reviewers

plasma-devel
arichardson

Commits

R109:5fd327369bc6: Port kded plugin to json metadata

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

heikobecker updated this revision to Diff 2058.Jan 21 2016, 6:25 PM

heikobecker retitled this revision from to Port kded plugin to json metadata.

heikobecker updated this object.

heikobecker edited the test plan for this revision. (Show Details)

heikobecker added a reviewer: plasma-devel.

arichardson added a subscriber: arichardson.Jan 21 2016, 7:41 PM

arichardson added inline comments.

CMakeLists.txt
79	Add SERVICE_TYPES kdedmodule.desktop here to ensure that all keys have the right type
84–85	Could be simplified to use `kcoreaddons_add_plugin(kded_kwrite SOURCES kwrited.cpp JSON "kwrited.json" INSTALL_NAMESPACE "kf5/kded")`

Used suggested kcoreaddons_add_plugin

Looks good to me once the JSON has been changed to use bool

kwrited.json
155	This and the following should be a boolean not a string. `desktoptojson -s kdedmodule.desktop -i $in -o $out` should correctly do that

This revision is now accepted and ready to land.Jan 23 2016, 5:04 PM

Closed by commit R109:5fd327369bc6: Port kded plugin to json metadata (authored by heikobecker). · Explain WhyJan 24 2016, 11:08 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (13 lines)
M			kwrited.cpp (5 lines)
A	M		kwrited.json (156 lines)

Diff 2081

CMakeLists.txt

Loading...

kwrited.cpp

Loading...

kwrited.json

Loading...