builds & installs fine
opened a couple of system palletes and created a new seemingly without issues
Details
Details
- Reviewers
heikobecker - Commits
- R534:40566b0f6e19: Initial port to KF/Qt5
Diff Detail
Diff Detail
- Repository
- R534 KColorEdit
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Now I wonder why it was dropped, apart from the lack of port - maybe there was something else that covers the same features? Need to dig.
Comment Actions
FindKF5 should require at least cmake-2.8.12
| CMakeLists.txt | ||
|---|---|---|
| 6 | Copy and paste? ;-) There's no cmake dir as far as I can see. | |
| 9 | The docs suggest to include this with NO_POLICY_SCOPE to get rid of cmake policy CMP0063 warnings. | |
| 12 | Already searched for earlier, why again? | |
| 13 | QT_MIN_VERSION is set earlier, but not used here. | |
Comment Actions
So, uh, where should I land it, frameworks branch or master? It just seems a bit moot to land it in a separate branch since most masters are now KF5 based anyway. Or it needs some work to be done before merged into master?
Comment Actions
@valeriymalov, kcoloredit is marked as "unmaintained" in sysadmin/repo-metadata. If you want to maintain it, please move away from it, probably into playground-graphics, adding yourself as maintainer, and then you can follow the workflow:
https://community.kde.org/Policies/Application_Lifecycle
That would allow us (kde-i18n) to re-enable the translations (we don't extract translations for repositories in unmaintained/).
About the missing bits, I'd suggest to work towards removed kdelibs4support before merging. I already restored the support for using the translation file if installed.