Discard button indicates that it will quit the program
AbandonedPublic

Authored by ngraham on Oct 25 2017, 5:47 PM.

Details

Summary

BUG: 386163

  • Spectacle's Discard button now says "Discard & Quit" to indicate that it will also quit the program
  • Changed "Save & Exit" to "Save & Quit" to be consistent.
  • Changed the docbook accordingly
  • Fixed a couple of nearby formatting and whitespace inconsistencies
Test Plan

Tested all changes in KDE Neon. Buttons have correct names and the "Discard & Quit" button still correctly turns into a "Quit" button if the screenshot has already been saved.

Diff Detail

Repository
R166 Spectacle
Branch
386163
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Oct 25 2017, 5:47 PM
ngraham edited the test plan for this revision. (Show Details)Oct 25 2017, 5:47 PM
ngraham added reviewers: Spectacle, broulik.
ngraham added a project: Spectacle.
ngraham edited the summary of this revision. (Show Details)Oct 25 2017, 5:50 PM
ngraham updated this revision to Diff 21462.Oct 28 2017, 2:30 AM
ngraham edited the summary of this revision. (Show Details)

Cleaned up Settings dialog

ngraham planned changes to this revision.Oct 28 2017, 2:32 AM

Oops.

ngraham updated this revision to Diff 21463.Oct 28 2017, 2:35 AM

Restored original diff

aacid added a subscriber: aacid.Oct 30 2017, 8:29 PM
aacid added inline comments.
src/Gui/KSMainWindow.cpp
208

You mentioned this should also be Quit?

ngraham added inline comments.Oct 30 2017, 9:12 PM
src/Gui/KSMainWindow.cpp
208

Oops, missed that one.

What do you think of just calling this "Quit"? It's consistent with the rest of the apps and the discard is implied as well.

ngraham added a comment.EditedOct 30 2017, 9:22 PM

The problem is that in Spectacle, Quit does not always imply discard. When you save an image but keep the main window open, there is no discard. I kind of like the explicitness: "Discard and Quit", along with the red trash icon, leaves no room for doubt what will happen.

ngraham updated this revision to Diff 21596.Oct 31 2017, 1:53 AM

Replaced Exit with Quit in a few places I missed earlier

ngraham marked 2 inline comments as done.Oct 31 2017, 1:54 AM

Does anyone from VDG have any opinions on this?

abetts requested changes to this revision.Nov 5 2017, 9:17 PM

How about even simpler:

Export Image
Copy to Clipboard
Save
Discard
Quit

Why does it "have" to be "save and quit" or "discard and quit"?

I find this behavior pretty annoying because hitting enter will save and close Spectacle, but what about if I want to keep working with it, well, you have to launch it a few times. You can do "Ctrl+S" to save, but it is not evident from current UI.

Thoughts?

This revision now requires changes to proceed.Nov 5 2017, 9:17 PM
ngraham added a comment.EditedNov 5 2017, 10:07 PM

It's redundant to have separate discard and quit buttons because discarding without quitting doesn't do anything.

The save button can be made to remember the last used save mode you used (it's hidden away in Settings, which is itself hidden under the save button: https://bugs.kde.org/show_bug.cgi?id=375965. I plan on fixing that soon, too.

ngraham abandoned this revision.Jan 31 2018, 6:33 PM

Abandoning since there's no real way to fix this given the current UI. We're tracking an overhaul in T7841: Revamp buttons on the bottom to solve various usability issues.