Differential D848

Fix issue with low-res image in Quick Open menu
ClosedPublic
Actions

Authored by Sergobot on Jan 21 2016, 3:16 PM.

Details

Reviewers
kfunk
Commits
R32:0990806927e7: Fix issue with low-res image in Quick Open menu
R33:0990806927e7: Fix issue with low-res image in Quick Open menu
Summary

Fix the 4th issue from https://phabricator.kde.org/T664 ("Quick Open: Pixmaps in list view items blocky")

Test Plan

Tests passed; pixmaps look fine with QT_DEVICE_PIXEL_RATIO=2 and fonts DPI forced to 192.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Sergobot updated this revision to Diff 2050.Jan 21 2016, 3:16 PM
Sergobot retitled this revision from to Fix issue with low-res image in Quick Open menu.
Sergobot updated this object.
Sergobot edited the test plan for this revision. (Show Details)
Sergobot added a reviewer: kfunk.
Sergobot added subscribers: KDevelop, kdevelop-devel.
Sergobot updated this object.Jan 21 2016, 3:17 PM
Sergobot added a project: KDevelop.
apol added a subscriber: apol.Jan 21 2016, 3:20 PM
apol added inline comments.
plugins/quickopen/expandingtree/expandingwidgetmodel.cpp
444

What happens if you change it to:

m_expandedIcon = QIcon::fromTheme(QStringLiteral("arrow-down"));
Sergobot edited the test plan for this revision. (Show Details)Jan 21 2016, 3:28 PM
Sergobot updated this revision to Diff 2052.Jan 21 2016, 3:44 PM
kfunk accepted this revision.Jan 21 2016, 3:50 PM
kfunk edited edge metadata.

LGTM.

Push to 5.0 branch please.

This revision is now accepted and ready to land.Jan 21 2016, 3:50 PM
Closed by commit R33:0990806927e7: Fix issue with low-res image in Quick Open menu (authored by Sergobot). · Explain WhyJan 21 2016, 5:01 PM
This revision was automatically updated to reflect the committed changes.
Sergobot marked an inline comment as done.

Revision Contents
Changeset List

Diff 2056

View Options

plugins/quickopen/expandingtree/expandingwidgetmodel.cpp

Loading...