Differential D8458

snore notification fails due to undefined CraftCore
AbandonedPublic
Actions

Authored by vonreth on Oct 25 2017, 3:44 AM.

Details

Reviewers
mhubner
Group Reviewers
Craft
Summary

Having snoresend configured, no messages get sent to snore because the CraftCore cannot be resolved:

name 'CraftCore' is not defined

Diff Detail

Repository
R138 Craft
Lint
Lint Skipped
Unit
Unit Tests Skipped
mhubner created this revision.Oct 25 2017, 3:44 AM
vonreth commandeered this revision.Oct 25 2017, 6:52 AM
vonreth added a reviewer: mhubner.
vonreth added a subscriber: vonreth.

Woooa thx for finding this issue.
The whole file ended up in a mess after the last refactoring.
the correct fix would have bin to from CraftCore import CraftCore
Taking CraftCore from CraftDebug as it was done all over here was a bit ugly.

When I had a look on this file I couldn't resist to also refactor it a bit so snore is working again, thex for your contribution.

vonreth abandoned this revision.Oct 25 2017, 6:52 AM

Revision Contents
Changeset List

PathPackages
Mbin/Notifier/Backends/Snore.py (2 lines)

Diff 21271

View Options

bin/Notifier/Backends/Snore.py

Loading...