Port kcm input to UI File.
ClosedPublic
Actions

Authored by xuetianweng on Oct 24 2017, 10:32 PM.

Details

Reviewers

romangg
davidedmundson
ngraham

Commits

R119:987b4dec9264: Port kcm input to UI File.

Summary

A split version of D8168. This only refactors the hardcoded ui constructor
into an equilvalent UI file. This change has no string change nor behavior
change.

Test Plan

Test config opton manually.

Diff Detail

Repository

R119 Plasma Desktop

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

xuetianweng created this revision.Oct 24 2017, 10:32 PM

Restricted Application added a project: Plasma. · View Herald TranscriptOct 24 2017, 10:32 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

I tested it and everything seems fine. But can we also get rid of the special "General" tab, i.e. the kmousedlg.ui file with its related KMouseDlg class, by integrating it into the kcmmouse.ui file like the other tabs? The class seems to be some unfinished remnant of a previous attempt of putting tabs into ui files.

Merge kmousedlg.ui into kcmmouse.ui.

romangg accepted this revision.Oct 25 2017, 2:37 AM

This revision is now accepted and ready to land.Oct 25 2017, 2:37 AM

Closed by commit R119:987b4dec9264: Port kcm input to UI File. (authored by xuetianweng). · Explain WhyOct 25 2017, 2:45 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		kcms/input/CMakeLists.txt (2 lines)
A	M	kcms/input/kcmmouse.ui (627 lines)
D	M	kcms/input/kmousedlg.ui (164 lines)
M		kcms/input/mouse.h (30 lines)
M		kcms/input/mouse.cpp (259 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	21262	658a9bf		Oct 24 2017, 10:32 PM	★	★
Diff 2	21268	658a9bf	Merge kmousedlg.ui into kcmmouse.ui.	Oct 25 2017, 1:16 AM	★	★
Diff 3	21269	658a9bf	R119:987b4dec9264c7c5bf53161b3a0fe37b3371efeb	Oct 25 2017, 2:45 AM	★	★