Fix crash in pulseaudio playback
ClosedPublic

Authored by elvisangelaccio on Oct 23 2017, 10:22 PM.

Details

Summary

pa_sample_size() calls pa_assert(pa_sample_spec_valid(spec)), so it will
crash if the spec is invalid.

We prevent this by checking the spec validity on our own.

Test Plan

Open Settings -> Playback, check that Pulseadio doesn't crash anymore.

Diff Detail

Repository
R347 KWave
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
the accepted this revision.Oct 24 2017, 3:49 AM

looks good, thanks!
Ship it!

This revision is now accepted and ready to land.Oct 24 2017, 3:49 AM
This revision was automatically updated to reflect the committed changes.