Differential D8419

Dict Engine: improve error handling.
ClosedPublic
Actions

Authored by dfaure on Oct 22 2017, 11:10 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:c2cf81f26bfe: Dict Engine: improve error handling.
Summary

Instead of returning "<dl>\n<dt><b></b></dt>\n<dd></dl>"
when the word doesn't exist, return a proper readable string so users
know that the lookup is done and nothing was found.

Test Plan

I'm porting the dict applet to QtQuick, review request coming soon.

Diff Detail

Repository
R120 Plasma Workspace
Branch
Plasma/5.11
Lint
No Linters Available
Unit
No Unit Test Coverage
dfaure created this revision.Oct 22 2017, 11:10 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 22 2017, 11:10 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Oct 22 2017, 4:55 PM
This revision is now accepted and ready to land.Oct 22 2017, 4:55 PM
broulik added a subscriber: broulik.Oct 23 2017, 8:13 AM

Don't you also need a Messages.sh and TRANSLATION_DOMAIN define?

dfaure added a comment.Oct 24 2017, 7:51 AM
In D8419#158645, @broulik wrote:

Don't you also need a Messages.sh and TRANSLATION_DOMAIN define?

Well spotted. The Messages.sh file was there, but not the define. Fixed and pushed.

Closed by commit R120:c2cf81f26bfe: Dict Engine: improve error handling. (authored by dfaure). · Explain WhyOct 24 2017, 7:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 21116

View Options

dataengines/dict/CMakeLists.txt

Loading...
View Options

dataengines/dict/dictengine.cpp

Loading...