Differential D8412

Fix compilation in a sustainable fashion
ClosedPublic
Actions

Authored by bcooksley on Oct 22 2017, 4:59 AM.

Details

Reviewers
apol
Commits
R495:e3e60a308cb1: Fix compilation on Windows (MSVC) and move to a more maintainable way of…
R495:ddff8ca2aae6: Fix compilation on Windows (MSVC) and move to a more maintainable way of…
Summary

As different platforms and compilers have different requirements in terms of quoting on the command line, getting the exact combination to keep Linux (gcc), FreeBSD (clang) and Windows (Visual Studio) happy is difficult.

If we instead transfer the path in via a definition in a file then these issues are skipped.
This is the same approach used by other Frameworks such as KIO.

Diff Detail

Repository
R495 Purpose Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bcooksley created this revision.Oct 22 2017, 4:59 AM
apol accepted this revision.Oct 23 2017, 10:18 AM
apol added inline comments.
src/externalprocess/processjob.cpp
40

The "/" in the end isn't needed.

This revision is now accepted and ready to land.Oct 23 2017, 10:18 AM
Closed by commit R495:e3e60a308cb1: Fix compilation on Windows (MSVC) and move to a more maintainable way of… (authored by bcooksley). · Explain WhyOct 23 2017, 5:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 21191

View Options

src/CMakeLists.txt

Loading...
View Options

src/cmake-paths.h.cmake

Loading...
View Options

src/externalprocess/processjob.cpp

Loading...