Differential D8364

Drop the explicit fallback to XRender
ClosedPublic
Actions

Authored by graesslin on Oct 18 2017, 8:07 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Plasma
Commits
R108:8f4b6a89731b: Drop the explicit fallback to XRender
Summary

With the new try of all compositor types supported there is an automatic
fallback from OpenGL to XRender/QPainter in case OpenGL setup failed.
So there is no need to invoke a method to do just that.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Oct 18 2017, 8:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 18 2017, 8:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Oct 18 2017, 9:54 PM
davidedmundson added a subscriber: davidedmundson.

Does anything now use Options::setCompositingMode?

This revision is now accepted and ready to land.Oct 18 2017, 9:54 PM
graesslin added a comment.Oct 19 2017, 3:42 PM
In D8364#157049, @davidedmundson wrote:

Does anything now use Options::setCompositingMode?

nope. Good catch, I'll drop that one as well.

Closed by commit R108:8f4b6a89731b: Drop the explicit fallback to XRender (authored by graesslin). · Explain WhyOct 19 2017, 4:27 PM
This revision was automatically updated to reflect the committed changes.
graesslin added a comment.Oct 19 2017, 6:32 PM
In D8364#157049, @davidedmundson wrote:

Does anything now use Options::setCompositingMode?

erm no idea what I checked before: it's still called from within options.

Revision Contents
Changeset List

PathPackages
Mcomposite.h (1 line)
Mcomposite.cpp (11 lines)
Mplugins/scenes/opengl/scene_opengl.cpp (1 line)

Diff 20984

View Options

composite.h

Loading...
View Options

composite.cpp

Loading...
View Options

plugins/scenes/opengl/scene_opengl.cpp

Loading...