Previously: Left part of some elements' text can disappear when expanded.
Now: Set leftMargin to background.itemWidth * 1.5 - background.itemWidth so that text wouldn't disappear when expanded.
Further, (as improvement), right margin adjusts according to window's width.
No overlapping occurs.
Details
Details
Diff Detail
Diff Detail
- Repository
- R2 GCompris
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
I think this fix should be part of the rework of the activity in https://phabricator.kde.org/T5935. I'm not sure this fix would stay the same after it so it would be better to first rework the activity and apply this one if needed once the rework has been done.
I guess we can attach this diff to the other fix (adding a note that it may be useful in case) and close the task currently associated to this diff.
src/activities/letter-in-word/LetterInWord.qml | ||
---|---|---|
292 | the other one? |
src/activities/letter-in-word/LetterInWord.qml | ||
---|---|---|
292 | oops, sorry. I think by mistake i had set topMargin: background.itemWidth * 0.5 , instead of leftMargin while creating the patch. However, I'll rework https://phabricator.kde.org/T5935 and update the correct diff to this then, if needed :) |