| aacid | |
| apol |
We already had a way to control that list from the system settings
thanks to previous changes. Now this is also exposed via API.
Note however that the blacklist coming from the settings can't be
ignored, we control via the API only an extra blacklist sitting on top.
Also, on desktop platforms, the blacklist contains "saveasplugin" by
default.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/alternativesmodel.h | ||
|---|---|---|
| 49 | Am I missing something or are we missing the implementation of this and the function below? | |
BTW i'm still a bit unconvinced by s_defaultDisabledPlugins being different depending on the platform, but if Aleix is fine with that who am i to complain 😄
| src/alternativesmodel.h | ||
|---|---|---|
| 49 | Woops, my bad, missed a clean up... | |
| src/alternativesmodel.cpp | ||
|---|---|---|
| 42 | Let's leave this static without ifdef for now. As soon as we start using Purpose properly on mobile devices let's revisit this. | |
Other than that, LGTM.
| autotests/alternativesmodeltest.cpp | ||
|---|---|---|
| 185 | You want to verify saveasplugin no? | |
| autotests/alternativesmodeltest.cpp | ||
|---|---|---|
| 185 | No, it's intentional. kdeconnectplugin is the one under test, it's just checking that a list with something else wouldn't accidentally blacklist it. | |