[Task Manager] Understand applications: URLs in Unity launchers

Authored by broulik on Oct 16 2017, 9:02 AM.



It only understood absolute desktop file paths so mapping would fail.

CHANGELOG: Fixed application progress in task manager no longer working

BUG: 385730
FIXED-IN: 5.11.1

Test Plan

I get progress when copying files in Dolphin again
I get a badge in my chat app again
Played around with unitylaunchertest in KNotifications and it seems to work
I didn't actually test apps with absolute launcher URLs as all my apps have a proper desktop file installed

Diff Detail

R119 Plasma Desktop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Oct 16 2017, 9:02 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 16 2017, 9:02 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Oct 16 2017, 9:10 AM
This revision is now accepted and ready to land.Oct 16 2017, 9:10 AM
anthonyfieroni added inline comments.

This check should be before init()? m_storageId can be empty but it can has an override one, no?

broulik added inline comments.Oct 16 2017, 10:06 AM

unityMappingRules().value(m_storageId); ← if m_storageId is empty, this call makes no sense?

broulik added inline comments.Oct 16 2017, 10:11 AM

But yeah I guess I'll move it to before init since the mapping rule might overwrite it to be empty

This revision was automatically updated to reflect the committed changes.