Differential D8318

KRunner: fix runtime warning when a runner links to QtWebEngine
AbandonedPublic
Actions

Authored by dfaure on Oct 15 2017, 9:12 PM.

Details

Reviewers
davidedmundson
broulik
Group Reviewers
Plasma
Summary

[this happens in the zanshin runner, due to libKF5AkonadiCalendar.so.5 linking
to libKF5AkonadiContact.so.5 linking to libKF5ContactEditor.so.5,
linking to QtWebEngine, but that's another story]

Test Plan

QT_FATAL_WARNINGS=1 krunner doesn't stop at this startup warning
anymore.

Diff Detail

Repository
R120 Plasma Workspace
Branch
Plasma/5.11
Lint
No Linters Available
Unit
No Unit Test Coverage
dfaure created this revision.Oct 15 2017, 9:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 15 2017, 9:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a comment.Oct 15 2017, 9:13 PM

Can't we fix the root-cause you mentioned? I still have memories of Akonadi runner trying to *initialize* Qt Web Engine and that blowing up miserably.

Alternatively, Zanshin could provide an out-of-process DBus runner.

apol added a subscriber: apol.Oct 15 2017, 9:50 PM

See https://phabricator.kde.org/D8214
Then https://bugs.kde.org/show_bug.cgi?id=385548

That said, I don't know if ShareOpenGLContext would be any worse.

dfaure abandoned this revision.Oct 16 2017, 7:38 AM

Ah OK. I'm using Plasma/5.11 so I didn't have that fix.

apol added a comment.Oct 16 2017, 8:55 AM

Note I never submitted the patch because Akonadi got fixed.

Revision Contents
Changeset List

PathPackages
Mkrunner/main.cpp (1 line)

Diff 20824

View Options

krunner/main.cpp

Loading...