This patch reenables the Calligra Gemini product for compilation, as it has now been ported, including a variety of other work required for Calligra Gemini to work (as well as a couple of other small changes which were done in the branch as i was working on it).
Details
Details
- Reviewers
Calligra-Devel-list staniek - Commits
- R8:1bbb6e00022b: Port Calligra Gemini for 3.x
This builds and runs on Windows and Linux, on the former of which i have been using Calligra Gemini 3.x as my daily driver for a few months now.
Diff Detail
Diff Detail
- Repository
- R8 Calligra
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Pinged on IRC on Friday and i'll just archive the chat here:
[27/10/2017 12:06:02] <leinir> if possible, i'd really like a review on this one... https://phabricator.kde.org/D8310
[27/10/2017 13:24:23] <boud> leinir: I am afraid that you really have to consider yourself the maintainer
[27/10/2017 13:30:56] <leinir> for gemini i've done that since, you know, a long time... but i guess if nobody steps up soonish, silence will have spoken
[27/10/2017 13:33:25] <boud> yes, well, I think it has spoken
I would like to think that i don't need to take quite as drastic action as that, but given the only responses so far have been in essence "go for it", i am starting to lean towards doing so.
Comment Actions
Dan Leinir Turthra Jensen skrev den 2017-10-30 12:06:
I hope ppl have just taken an extended summer vacation ;)
Comment Actions
+1 from me, appeciated the port!
- have not run it
- have not reviewed the QML part
| filters/words/msword-odf/wv2/CMakeLists.txt | ||
|---|---|---|
| 3 | Convention: | |
| gemini/lib/GeminiMainWindow.cpp | ||
| 31 | Convention: case-sensitive or clang will warn: Shellapi.h | |
| gemini/main.cpp | ||
| 88 | Maybe QFile::encodeName instead of toLocal8Bit | |