Modernize: Use nullptr where possible
ClosedPublic
Actions

src/backtracegenerator.cpp
69	`Q_ASSERT(!m_proc && !m_temp)`? iirc Clang doesn't like comparisons to `nullptr` very much (at least in `QCOMPARE`) and I find it cleaner
src/crashedapplication.cpp
98	`name ? name : "Unknown"`?
src/drkonqi.cpp
83	could be simplified to `static DrKonqi *drKonqiInstance = new DrKonqi();` or even created on the stack and return address (just noticed, not what this patch is about obviously)

This revision is now accepted and ready to land.Oct 15 2017, 12:31 PM

sitter accepted this revision.Oct 15 2017, 3:39 PM

kfunk marked an inline comment as done.Oct 15 2017, 4:44 PM

kfunk added inline comments.

src/backtracegenerator.cpp
69	That can't be problem. This code will compile fine. `QCOMPARE(a,nullptr)` since this is triggering some template instantiations which might fail to deduce the correct pointer type for the rhs. Fixed it anyhow :)

Closed by commit R871:abb6999b736b: Modernize: Use nullptr where possible (authored by kfunk). · Explain WhyOct 15 2017, 4:45 PM

This revision was automatically updated to reflect the committed changes.

kfunk marked an inline comment as done.

Revision Contents
Changeset List

			Path	Packages
M			src/aboutbugreportingdialog.h (2 lines)
M			src/backtracegenerator.cpp (14 lines)
M			src/backtracewidget.h (2 lines)
M			src/backtracewidget.cpp (4 lines)
M			src/bugzillaintegration/bugzillalib.h (4 lines)
M			src/bugzillaintegration/bugzillalib.cpp (6 lines)
M			src/bugzillaintegration/duplicatefinderjob.h (2 lines)
M			src/bugzillaintegration/parsebugbacktraces.h (2 lines)
M			src/bugzillaintegration/productmapping.h (2 lines)
M			src/bugzillaintegration/reportassistantdialog.h (2 lines)
M			src/bugzillaintegration/reportassistantdialog.cpp (2 lines)
M			src/bugzillaintegration/reportassistantpages_bugzilla.cpp (4 lines)
M			src/bugzillaintegration/reportassistantpages_bugzilla_duplicates.h (2 lines)
M			src/bugzillaintegration/reportinterface.h (2 lines)
M			src/crashedapplication.h (2 lines)
M			src/crashedapplication.cpp (6 lines)
M			src/debuggerlaunchers.h (6 lines)
M			src/debuggermanager.h (2 lines)
M			src/debugpackageinstaller.h (2 lines)
M			src/debugpackageinstaller.cpp (10 lines)
M			src/detachedprocessmonitor.h (2 lines)
M			src/drkonqi.h (2 lines)
M			src/drkonqi.cpp (2 lines)
M			src/drkonqidialog.h (2 lines)
M			src/drkonqidialog.cpp (4 lines)
M			src/parser/backtraceparser.h (4 lines)
M			src/parser/backtraceparser.cpp (2 lines)
M			src/parser/backtraceparsergdb.h (2 lines)
M			src/parser/backtraceparserkdbgwin.h (2 lines)
M			src/parser/backtraceparsernull.h (2 lines)
M			src/statuswidget.h (4 lines)
M			src/systeminformation.h (2 lines)
M			src/tests/backtraceparsertest/backtraceparsertest.h (2 lines)
M			src/tests/backtraceparsertest/fakebacktracegenerator.h (2 lines)
M			src/tests/crashtest/crashtest.cpp (2 lines)