macOS: Don't create bundles for test executables
ClosedPublic

Authored by kfunk on Oct 15 2017, 12:20 PM.

Diff Detail

Repository
R871 DrKonqi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk created this revision.Oct 15 2017, 12:20 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 15 2017, 12:20 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol accepted this revision.Oct 15 2017, 1:41 PM
apol added a subscriber: apol.
apol added inline comments.
src/tests/backtraceparsertest/CMakeLists.txt
7–8

Maybe we could assume tests are non_gui by default?

This revision is now accepted and ready to land.Oct 15 2017, 1:41 PM
sitter accepted this revision.Oct 15 2017, 3:35 PM
rjvbb accepted this revision.Oct 15 2017, 3:41 PM
rjvbb added inline comments.
src/tests/backtraceparsertest/CMakeLists.txt
7–8

For Mac there is only a theoretical difference in fact; nongui builds are non-bundled but you have to try really hard nowadays to find an application that doesn't work properly without being in an app bundle.

As long as you don't want to test integration with LaunchServices, that is.

kfunk added inline comments.Oct 15 2017, 4:51 PM
src/tests/backtraceparsertest/CMakeLists.txt
7–8

ecm_add_test(...) does that. ecm_mark_as_test(...) doesn't. Might make sense to change that for ecm_mark_as_test(...), indeed.

This revision was automatically updated to reflect the committed changes.