when no music is playing, klicking the play button from the playlist view does not start music playback.
fix this by passing down the playerControl to playlistentry and add the call to start playback
Details
Details
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Thanks a lot for this. This is a much needed modification. This adds consistency (the same button as the same effect).
While reading your patch, I thought that it might be better to use signals. This should help reduce tight coupling between the components.
Could you modify it to use signals to only have calls to manageAudioPlayer in MediaServer component ?
I believe I will mass modify all the other actions to follow the same pattern.
Comment Actions
Updated the patch to use signals instead of using manageAudioPlayer directly. The name of the id for PlayListEntry seems somewhat false, but I left it unchanged for now.
Since this is my first try at Qt/QML development and my very first contribution, you might want to take a closer look if it is really what you intended :)