Rework the table so it's more easily expandable
ClosedPublic

Authored by aacid on Oct 12 2017, 10:08 PM.

Diff Detail

Repository
R456 Lokalize
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Oct 12 2017, 10:08 PM
pino requested changes to this revision.Oct 13 2017, 5:25 AM
pino added inline comments.
src/catalog/gettextheader.cpp
57–98

static const

131–135

This search loop here is ugly. I guess a followup patch to fix it would be nice..

This revision now requires changes to proceed.Oct 13 2017, 5:26 AM
aacid updated this revision to Diff 20836.Oct 15 2017, 10:27 PM

Made static const

aacid marked an inline comment as done.Oct 15 2017, 10:27 PM
aacid added inline comments.
src/catalog/gettextheader.cpp
131–135

Unrelated to my fixes, i can review a patch of yours if you send it :)

aacid added a comment.Oct 30 2017, 4:25 PM

i'll commit this next week if noone disagrees.

This revision was automatically updated to reflect the committed changes.