Correcting symlinks between col- and row-resize and split_v and _h cursors
ClosedPublic

Authored by ostroffjh on Oct 12 2017, 4:10 PM.

Diff Detail

Repository
R113 Oxygen Theme
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ostroffjh created this revision.Oct 12 2017, 4:10 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 12 2017, 4:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cfeck added a subscriber: cfeck.Oct 17 2017, 1:04 AM

Not 100% sure, but I think those symlinks were created by a script or template. Could you check if there are other references to those wrong names in the Oxygen cursors source?

Doing 'grep -ir "-resize" *' in the root of the repository returns no hits, I also looked at the results of grepping for resize and for split, and didn't see anything relevant.

ping - anyone here to give a ship it? ;)

Is there a problem with this, or has it simply fallen through the cracks?

asturmlechner added a subscriber: apol.EditedFeb 11 2018, 12:37 PM

It seems to me there was no change to these files since they were imported into this repository with 8ba33ca2a934dc1f2a34659eab1eef11f89c170c, so the issue must predate that.

tfoster added a subscriber: tfoster.Mar 6 2018, 6:36 PM
In D8267#156392, @cfeck wrote:

Not 100% sure, but I think those symlinks were created by a script or template. Could you check if there are other references to those wrong names in the Oxygen cursors source?

I believe this is correct. I'm seeing the wrong names in cursors/src/symlinks/col-resize and cursors/src/symlinks/row-resize as well. These two files should also be fixed.

ostroffjh updated this revision to Diff 36177.Jun 14 2018, 7:46 PM
  • Merge branch 'master' into fixlinks
  • fix cursors/src/symlinks/col-resize and .../row-resize

Updating D8267: Correcting symlinks between col- and row-resize and split_v and _h

Bug 384864

Fixed those two symlinks and updated the diff. Anything else blocking this?

ping - could we get this in for 5.14?

rdieter added a subscriber: rdieter.Aug 1 2018, 7:02 PM
cfeck accepted this revision.Aug 30 2018, 9:55 PM
This revision is now accepted and ready to land.Aug 30 2018, 9:55 PM
cfeck retitled this revision from Correcting symlinks between col- and row-resize and split_v and _h Bug 384864 to Correcting symlinks between col- and row-resize and split_v and _h cursors.Aug 30 2018, 9:57 PM
cfeck edited the summary of this revision. (Show Details)

I tried "arc land" but get
Landing current branch 'fixlinks'.
TARGET Landing onto "master", the default target under git.
REMOTE Using remote "origin", the default remote under git.
FETCH Fetching origin/master...
These commits will be landed:

  • 78cc89b2 fix cursors/src/symlinks/col-resize and .../row-resize to point to correct source
  • 9b4ced83 Merge branch 'master' into fixlinks
  • f6260cea Correcting symlinks between col- and row-resize and split_v and _h Bug 384864

Landing revision 'D8267: Correcting symlinks between col- and row-resize and split_v and _h cursors'...
BUILDS PASSED Harbormaster builds for the active diff completed successfully.
PUSHING Pushing changes to "origin/master".
fatal: remote error: service not enabled: /oxygen.git
Usage Exception: Push failed! Fix the error and run "arc land" again.

Do I have something set up incorrectly for this?

If you still have the commits locally just rebase and push, Phabricator is smart enough to close this.

Otherwise I find arc patch far more reliable than arc land.

This revision was automatically updated to reflect the committed changes.

My problem was that I had originally cloned from anongit, so of course any push would fail. I did a fresh clone, "arc patch," and then "arc land" worked just fine.