BUG: 384864
Details
- Reviewers
apol cfeck - Group Reviewers
Plasma - Commits
- R113:5bf9dfe906b5: Correcting symlinks between col- and row-resize and split_v and _h cursors
Diff Detail
- Repository
- R113 Oxygen Theme
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Not 100% sure, but I think those symlinks were created by a script or template. Could you check if there are other references to those wrong names in the Oxygen cursors source?
Doing 'grep -ir "-resize" *' in the root of the repository returns no hits, I also looked at the results of grepping for resize and for split, and didn't see anything relevant.
It seems to me there was no change to these files since they were imported into this repository with 8ba33ca2a934dc1f2a34659eab1eef11f89c170c, so the issue must predate that.
I believe this is correct. I'm seeing the wrong names in cursors/src/symlinks/col-resize and cursors/src/symlinks/row-resize as well. These two files should also be fixed.
- Merge branch 'master' into fixlinks
- fix cursors/src/symlinks/col-resize and .../row-resize
Updating D8267: Correcting symlinks between col- and row-resize and split_v and _h
Bug 384864
I tried "arc land" but get
Landing current branch 'fixlinks'.
TARGET Landing onto "master", the default target under git.
REMOTE Using remote "origin", the default remote under git.
FETCH Fetching origin/master...
These commits will be landed:
- 78cc89b2 fix cursors/src/symlinks/col-resize and .../row-resize to point to correct source
- 9b4ced83 Merge branch 'master' into fixlinks
- f6260cea Correcting symlinks between col- and row-resize and split_v and _h Bug 384864
Landing revision 'D8267: Correcting symlinks between col- and row-resize and split_v and _h cursors'...
BUILDS PASSED Harbormaster builds for the active diff completed successfully.
PUSHING Pushing changes to "origin/master".
fatal: remote error: service not enabled: /oxygen.git
Usage Exception: Push failed! Fix the error and run "arc land" again.
Do I have something set up incorrectly for this?
If you still have the commits locally just rebase and push, Phabricator is smart enough to close this.
Otherwise I find arc patch far more reliable than arc land.
My problem was that I had originally cloned from anongit, so of course any push would fail. I did a fresh clone, "arc patch," and then "arc land" worked just fine.