Differential D8266

Fix QFile::copy warning when the colors file doesn't exist
ClosedPublic
Actions

Authored by dfaure on Oct 12 2017, 2:35 PM.

Details

Reviewers
mart
davidedmundson
Commits
R119:df6658eee5c6: Fix QFile::copy warning when the colors file doesn't exist
Summary

There is no need to even look for a "Default.colors" file when
using the default color scheme, so skip the entire file copying
in that case.

Test Plan

Just checked that the warning went away, I didn't test
the kde4 interaction.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure created this revision.Oct 12 2017, 2:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 12 2017, 2:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Oct 14 2017, 5:57 AM
This revision is now accepted and ready to land.Oct 14 2017, 5:57 AM
Closed by commit R119:df6658eee5c6: Fix QFile::copy warning when the colors file doesn't exist (authored by dfaure). · Explain WhyOct 14 2017, 6:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/krdb/krdb.cpp (46 lines)

Diff 20711

View Options

kcms/krdb/krdb.cpp

Loading...