Change kcm header "Select Login Theme" to "Configure the SDDM Login Manager"
ClosedPublic

Authored by aspotashev on Oct 12 2017, 1:29 PM.

Details

Summary

Change kcm header "Select Login Theme" to "Configure the SDDM Login
Manager" because it's not only about the theme, you can also setup
autologin and set the halt and reboot commands.

Diff Detail

Repository
R123 SDDM Configuration Panel (KCM)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aspotashev created this revision.Oct 12 2017, 1:30 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 12 2017, 1:30 PM
davidedmundson requested changes to this revision.Oct 12 2017, 1:36 PM
davidedmundson added a subscriber: davidedmundson.

I don't want to put "SDDM" in the UI.
It won't mean anything to most people.

Login theme -> login manager makes sense though.

This revision now requires changes to proceed.Oct 12 2017, 1:36 PM

"Configure Login Manager" sounds OK?

Frankly the term "login manager" won't mean much to most people either, but I agree that we shouldn't hardcode the name of a particular one in the UI, since this is a modular component.

"Configure Login Manager" sounds good to me.

aspotashev updated this revision to Diff 20652.Oct 12 2017, 4:59 PM

update to "Configure Login Manager"

ngraham accepted this revision.Oct 12 2017, 4:59 PM
This revision was automatically updated to reflect the committed changes.

Hmm, probably should have waited until David could sign off too, since he had an outstanding request-for-changes review.

rkflx added a subscriber: rkflx.Oct 12 2017, 7:25 PM

@ngraham: It's probably okay since David already worded it that way, but next time I'd suggest to review the commit message more carefully ;)

Oh right of course, because the title becomes the commit message. I'll remember in the future.