[LauncherTasksModel] Try resolving absolute path to applications: URL before adding launcher
ClosedPublic

Authored by broulik on Oct 12 2017, 9:14 AM.

Details

Summary

This way when a third party like pinning or dragging from Kickoff sends an absolute desktop file path we would still only store the application id if possible.

Test Plan

Pinned Dolphin from Kickoff, resulted in applications:org.kde.dolphin.desktop being stored in plasma rc. Kickoff would still know that the item is already pinned (ie. entry no longer shown in context menu)

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Oct 12 2017, 9:14 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 12 2017, 9:14 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

I can confirm that this fixes the drag n dropped launchers behavior

davidedmundson accepted this revision.Oct 14 2017, 7:17 AM
davidedmundson added a subscriber: davidedmundson.

Same as the other patch:
menuId is autogenerated from the filename, so why go via KService to find something we already know?

But it's the same as that other patch. Submit this so things work, and we can let eike optimise afterwards.

This revision is now accepted and ready to land.Oct 14 2017, 7:17 AM
This revision was automatically updated to reflect the committed changes.