Differential D826

Fix kdevfiletemplates previews on Windows
ClosedPublic
Actions

Authored by arrowd on Jan 15 2016, 9:15 AM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R33:f5b47d66129e: Fix kdevfiletemplates previews on Windows
R32:f5b47d66129e: Fix kdevfiletemplates previews on Windows
Summary

Due to wrong condition it tried to use KTar to unpack zip files. No idea how it
is working on *nix-like systems.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arrowd updated this revision to Diff 1977.Jan 15 2016, 9:15 AM
arrowd retitled this revision from to Fix kdevfiletemplates previews on Windows.
arrowd updated this object.
arrowd edited the test plan for this revision. (Show Details)
arrowd added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 15 2016, 9:15 AM
kfunk accepted this revision.Jan 15 2016, 9:37 AM
kfunk added a reviewer: kfunk.
kfunk added a subscriber: kfunk.

Prints "zip" or "bzip2" here, too... So this is broken on Unix as well.

Go for it. Thanks!

This revision is now accepted and ready to land.Jan 15 2016, 9:37 AM
Closed by commit R33:f5b47d66129e: Fix kdevfiletemplates previews on Windows (authored by arrowd). · Explain WhyJan 15 2016, 11:02 AM
This revision was automatically updated to reflect the committed changes.
arrowd mentioned this in R33:f5b47d66129e: Fix kdevfiletemplates previews on Windows.

Revision Contents
Changeset List

Diff 1981

View Options

language/codegen/sourcefiletemplate.cpp

Loading...