hein ngraham mvourlakos
- Group Reviewers
- R120:88dbb40ddede: [Task Tools] Treat applications: and respective absolute path equal in…
Having a file:///usr/share/applications/org.kde.dolphin.desktop launcher is no longer juggled around as I launch and quit Dolphin. Thanks Michail and Nate for pointing me to the right place (launcherPosition)
launcherUrslMatch is in a somewhat hot path that is called a lot.
If we have to do this, fine, but if there's an alternative; such as resolving the launcher to a KService (KService::serviceByMenuId) once in the launcher, that would be IMHO much much better.
Also menuId is built from the filename; (vfolder_menu.cpp:947) (prefix in that line is empty for anything non-supersuper-legacy)
Is there a reason we can't just compare filenames here?
Don't know, I just looked at what the rest of the code dealing with applications: URLs does.