Add a "share" menu to Okular
ClosedPublic

Authored by ervin on Oct 11 2017, 12:52 PM.

Details

Summary

This is implemented using the Purpose framework.

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin created this revision.Oct 11 2017, 12:52 PM
Restricted Application added a project: Okular. · View Herald TranscriptOct 11 2017, 12:52 PM
Restricted Application added a subscriber: Okular. · View Herald Transcript
aacid requested changes to this revision.Oct 11 2017, 12:55 PM

Can you please make the dependency on purpose optional?

This revision now requires changes to proceed.Oct 11 2017, 12:55 PM
aacid added a comment.Oct 11 2017, 3:13 PM

Can you investigate if there's a way to disable the Save As plugin?

It makes zero sense for Okular

part.cpp
3160

image -> document

3163

I'm wondering, if it just worked and there's nothing to really report maybe we can just use a

d->messageWindow->display(  .... );

that is far less intrusive?

ervin updated this revision to Diff 20598.Oct 11 2017, 3:24 PM

Making the purpose dependency optional

aacid added inline comments.Oct 11 2017, 3:33 PM
CMakeLists.txt
76

Please also add a set_package_properties so that people see what they are missing because they don't have purpose installed

ervin updated this revision to Diff 20601.Oct 11 2017, 3:36 PM

Address aacid's comments

ervin updated this revision to Diff 20605.Oct 11 2017, 3:45 PM

Addressing extra comment

aacid added a subscriber: apol.Oct 11 2017, 4:13 PM

Added Aleix to here so we can to come to an agreement of what's the best way to disable the "Save As" plugin

aacid added a comment.Oct 13 2017, 8:03 AM

https://phabricator.kde.org/D8262 is a possible solution for disabling Save As though Aleix doesn't seem very happy about it

Kevin had another option which was finding the saveas action using its action->property("pluginId") and just deleting it, i think that is a bit of a hack but if we can't agree on a better solution it may be an acceptable workaround.

Note the dependency freeze for KDE Applications is in November 9, hope we can get to an agreement before that :)

aacid accepted this revision.Oct 18 2017, 2:01 PM
This revision is now accepted and ready to land.Oct 18 2017, 2:01 PM
This revision was automatically updated to reflect the committed changes.