Port finite() -> std::isfinite()
ClosedPublic

Authored by kfunk on Oct 10 2017, 9:36 AM.

Details

Summary

Seems like std::isfinite() is the proper successor, cf.
https://bytes.com/topic/c/answers/217761-finite-ansi-c

Attempt to make this compile under MSVC

Diff Detail

Repository
R334 KmPlot
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk created this revision.Oct 10 2017, 9:36 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptOct 10 2017, 9:36 AM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
kfunk updated this revision to Diff 20552.Oct 10 2017, 9:40 AM

Remove all the work-arounds for isnan/isinf -- no longer needed iiuc

anthonyfieroni added inline comments.
kmplot/view.cpp
271 ↗(On Diff #20552)

As a suggest, first check for finite then make comparison.

@anthonyfieroni I'd just like to port this to the standard std::isfinite function, no other changes intended.

apol accepted this revision.Oct 15 2017, 1:39 PM
This revision is now accepted and ready to land.Oct 15 2017, 1:39 PM
This revision was automatically updated to reflect the committed changes.