Differential D8226

use icon filename for systray icon instead of sending pixmap over D-Bus
ClosedPublic
Actions

Authored by mkoller on Oct 9 2017, 5:04 PM.

Details

Reviewers
mlaurent
Commits
R206:07a3e9aecc5e: use icon filename for systray icon instead of sending pixmap over D-Bus
Summary

The KStatusNotifierItem doc says: "Whenever possible you should prefer passing icon by name rather than by pixmap"
Since kmail no longer overlays the icon with the unread number, there's no need to send actual pixmap data.

Diff Detail

Repository
R206 KMail
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkoller created this revision.Oct 9 2017, 5:04 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 9 2017, 5:04 PM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
mlaurent accepted this revision.Oct 10 2017, 4:40 AM
This revision is now accepted and ready to land.Oct 10 2017, 4:40 AM
Closed by commit R206:07a3e9aecc5e: use icon filename for systray icon instead of sending pixmap over D-Bus (authored by mkoller). · Explain WhyOct 10 2017, 5:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kmsystemtray.h (2 lines)
Msrc/kmsystemtray.cpp (5 lines)

Diff 20548

View Options

src/kmsystemtray.h

Loading...
View Options

src/kmsystemtray.cpp

Loading...