Move URL handlers to the new plugin interface
ClosedPublic

Authored by vkrause on Oct 7 2017, 11:20 AM.

Diff Detail

Repository
R81 KDE PIM Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Oct 7 2017, 11:20 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 7 2017, 11:20 AM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
knauss added inline comments.Oct 9 2017, 9:11 AM
plugins/messageviewer/bodypartformatter/calendar/text_calendar.json
6

can't this be empty at the moment, because only the urlHandler is used.

plugins/messageviewer/bodypartformatter/gnupgwks/gnupgwks.json
8

should be GnuPGWKSMessagePart and PgpKeyMessagePart

plugins/messageviewer/bodypartformatter/vcard/text_vcard.json
6

can't this be empty at the moment, because only the urlHandler is used.

It can't be empty as the plugin loader will expect something in there, but this gets addressed in the subsequent porting patches anyway.

knauss accepted this revision.Oct 10 2017, 8:45 AM

Yeah with the other patches this gets already addressed.

This revision is now accepted and ready to land.Oct 10 2017, 8:45 AM
This revision was automatically updated to reflect the committed changes.