Move URL handling from the processing to the rendering plugin
ClosedPublic

Authored by vkrause on Oct 7 2017, 11:20 AM.

Details

Summary

As a side-effect of the now gone URL handling dependency in the BPF
factory we can now merge the BPF factory code all into MTP rather than
splitting it over two libraries.

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Oct 7 2017, 11:20 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 7 2017, 11:20 AM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
knauss added inline comments.Oct 9 2017, 8:59 AM
mimetreeparser/src/viewer/bodypartformatterfactory.cpp
156

no the idea is that in mimetreeparser there is no plugin loader, this should be in messageviewer. Because the plugins may be specific for a specific messageviewer, that's why the messageviewer needs to control this. For Kube as example the plugins would need different plugins, becuase tithey support a different set. That was the base idea of this BaseFactory to give full control ovr the plugins to the messageviewer.

vkrause added inline comments.Oct 9 2017, 7:17 PM
mimetreeparser/src/viewer/bodypartformatterfactory.cpp
156

The solution for that is adding a way to change the plugin search path (or add some other way of filtering the plugins by additional metadata), not to duplicate the entire plugin loading code. This becomes even more relevant once we add on-demand plugin loading, when this wont be a single function anymore.
Your approach would also mean we would never be able to use MTP stand-alone without MV, but I think e.g. our composer would actually only need MTP, not the full MV.

knauss accepted this revision.Oct 14 2017, 3:43 PM
This revision is now accepted and ready to land.Oct 14 2017, 3:43 PM
This revision was automatically updated to reflect the committed changes.