Differential D8174

Port to new signal/slot syntax
ClosedPublic
Actions

Authored by malteveerman on Oct 7 2017, 11:18 AM.

Details

Reviewers

markey

Group Reviewers

Amarok

Commits

R181:1b81541eb2de: Port to new signal/slot syntax

Summary

This is the first part of my rather large pull request here: Reviewboard
It ports much of the code to the new signal/slot syntax, which makes it easier to spot errors during the rest of the porting process.
I changed some signal/slot names, because the new syntax doesn't handle overloads particularly well and added some new ones, because the new syntax doesn't handle default arguments at all.
Nothing too major, though.
This is the first time I created a revision with arcanist. I'm not sure it knows this is based on the kf5 branch. Let me know if I did anything wrong here.

Diff Detail

Repository

R181 Amarok

Branch

qt5/kf5

Lint

Lint Skipped

Unit

Unit Tests Skipped

malteveerman created this revision.Oct 7 2017, 11:18 AM

malteveerman edited the summary of this revision. (Show Details)

rikmills added a subscriber: rikmills.Oct 7 2017, 8:06 PM

markey added a subscriber: markey.Oct 8 2017, 1:20 PM

Hi Malte, I've applied your patch with Arcanist and then pushed it to remote. Before pushing I had to fix your author name and email though. KDE git hook refused your original author name because it was just one word.

Please fix your settings so that your real name and email address appear as author.

This revision is now accepted and ready to land.Oct 8 2017, 4:00 PM

markey closed this revision.Oct 8 2017, 4:11 PM

Not sure if it's any help...

I have compiled the branch kf5 which seem to contain this patches.

Everything seems to go smoothly until the compilation finishes and I try to run the application:

"Amarok could not find any plugins. This indicates an installation problem."

And then it quits.

There are no changes to the plugin system in this revision. Please try this and see if that fixes your issue.

yaohanchen added a subscriber: yaohanchen.Oct 25 2017, 7:15 AM

tbettler added a subscriber: tbettler.Dec 18 2017, 8:40 PM

Large Diff

This large diff affects 349 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

			Path	Packages
M			src/ActionClasses.cpp (34 lines)
M			src/AmarokMimeData.cpp (7 lines)
M			src/AmarokProcess.cpp (9 lines)
M			src/App.h (4 lines)
M			src/App.cpp (42 lines)
M			src/EngineController.h (8 lines)
M			src/EngineController.cpp (70 lines)
M			src/KNotificationBackend.cpp (6 lines)
M			src/MainWindow.cpp (142 lines)
M			src/MediaDeviceCache.cpp (20 lines)
M			src/MediaDeviceMonitor.cpp (14 lines)
M			src/OpmlParser.cpp (8 lines)
M			src/SvgHandler.cpp (2 lines)
M			src/TrayIcon.h (4 lines)
M			src/TrayIcon.cpp (43 lines)
M			src/aboutdialog/ExtendedAboutDialog.h (3 lines)
M			src/aboutdialog/ExtendedAboutDialog.cpp (40 lines)
M			src/aboutdialog/OcsPersonItem.cpp (6 lines)
M			src/aboutdialog/OcsPersonListWidget.cpp (4 lines)
M			src/aboutdialog/libattica-ocsclient/CMakeLists.txt (2 lines)
M			src/aboutdialog/libattica-ocsclient/activitylistjob.cpp (14 lines)
M			src/aboutdialog/libattica-ocsclient/categorylistjob.cpp (14 lines)
M			src/aboutdialog/libattica-ocsclient/contentjob.cpp (14 lines)
M			src/aboutdialog/libattica-ocsclient/contentlistjob.cpp (14 lines)
M			src/aboutdialog/libattica-ocsclient/eventjob.cpp (13 lines)
M			src/aboutdialog/libattica-ocsclient/eventlistjob.cpp (13 lines)
M			src/aboutdialog/libattica-ocsclient/folderlistjob.cpp (14 lines)
M			src/aboutdialog/libattica-ocsclient/knowledgebasejob.cpp (14 lines)
M			src/aboutdialog/libattica-ocsclient/knowledgebaselistjob.cpp (14 lines)
M			src/aboutdialog/libattica-ocsclient/messagelistjob.cpp (14 lines)
M			src/aboutdialog/libattica-ocsclient/personjob.cpp (27 lines)
M			src/aboutdialog/libattica-ocsclient/personlistjob.cpp (22 lines)
M			src/aboutdialog/libattica-ocsclient/postjob.cpp (14 lines)
M			src/aboutdialog/libattica-ocsclient/providerinitjob.cpp (2 lines)
M			src/amarokurls/AmarokUrlAction.cpp (4 lines)
M			src/amarokurls/BookmarkCurrentButton.cpp (2 lines)
M			src/amarokurls/BookmarkManagerWidget.cpp (8 lines)
M			src/amarokurls/BookmarkMetaActions.cpp (6 lines)
M			src/amarokurls/BookmarkTreeView.h (2 lines)
M			src/amarokurls/BookmarkTreeView.cpp (18 lines)
M			src/browsers/BrowserBreadcrumbItem.cpp (16 lines)
M			src/browsers/BrowserBreadcrumbWidget.cpp (6 lines)
M			src/browsers/BrowserCategory.cpp (4 lines)
M			src/browsers/BrowserCategoryList.cpp (12 lines)
M			src/browsers/BrowserDock.cpp (6 lines)
M			src/browsers/BrowserMessageArea.h (8 lines)
M			src/browsers/BrowserMessageArea.cpp (28 lines)
M			src/browsers/CollectionTreeItem.cpp (6 lines)
M			src/browsers/CollectionTreeItemModel.cpp (10 lines)
M			src/browsers/CollectionTreeItemModelBase.h (17 lines)
M			src/browsers/CollectionTreeItemModelBase.cpp (52 lines)
M			src/browsers/CollectionTreeView.h (3 lines)
M			src/browsers/CollectionTreeView.cpp (74 lines)
M			src/browsers/SingleCollectionTreeItemModel.cpp (2 lines)
M			src/browsers/collectionbrowser/CollectionWidget.cpp (37 lines)
M			src/browsers/filebrowser/FileBrowser.h (8 lines)
M			src/browsers/filebrowser/FileBrowser.cpp (48 lines)
M			src/browsers/filebrowser/FileBrowser_p.h (4 lines)
M			src/browsers/filebrowser/FileView.h (1 line)
M			src/browsers/filebrowser/FileView.cpp (25 lines)
M			src/browsers/playlistbrowser/APGCategory.cpp (30 lines)
M			src/browsers/playlistbrowser/DynamicBiasDialog.cpp (28 lines)
M			src/browsers/playlistbrowser/DynamicCategory.cpp (30 lines)
M			src/browsers/playlistbrowser/DynamicView.cpp (24 lines)
M			src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp (18 lines)
M			src/browsers/playlistbrowser/PlaylistBrowserModel.cpp (18 lines)
M			src/browsers/playlistbrowser/PlaylistBrowserView.cpp (24 lines)
M			src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp (16 lines)
M			src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp (11 lines)
M			src/browsers/playlistbrowser/PodcastCategory.cpp (10 lines)
M			src/browsers/playlistbrowser/QtGroupingProxy.cpp (27 lines)
M			src/browsers/servicebrowser/ServiceBrowser.cpp (3 lines)
M			src/configdialog/ConfigDialog.cpp (6 lines)
M			src/configdialog/dialogs/CollectionConfig.cpp (10 lines)
M			src/configdialog/dialogs/DatabaseConfig.cpp (8 lines)
M			src/configdialog/dialogs/ExcludedLabelsDialog.cpp (14 lines)
M			src/configdialog/dialogs/MetadataConfig.cpp (46 lines)
M			src/configdialog/dialogs/NotificationsConfig.cpp (34 lines)
M			src/configdialog/dialogs/PlaybackConfig.cpp (6 lines)
M			src/configdialog/dialogs/PluginsConfig.cpp (7 lines)
M			src/configdialog/dialogs/ScriptSelector.cpp (2 lines)
M			src/configdialog/dialogs/ScriptsConfig.cpp (26 lines)
M			src/context/ToolbarView.cpp (30 lines)
M			src/context/popupdropper/libpud/PopupDropper.cpp (38 lines)
M			src/context/popupdropper/libpud/PopupDropperItem.cpp (8 lines)
M			src/context/popupdropper/libpud/PopupDropper_p.h (2 lines)
M			src/core-impl/capabilities/AlbumActionsCapability.cpp (2 lines)
M			src/core-impl/capabilities/multisource/MultiSourceCapabilityImpl.cpp (2 lines)
M			src/core-impl/collections/aggregate/AggregateCollection.h (2 lines)
M			src/core-impl/collections/aggregate/AggregateCollection.cpp (4 lines)
M			src/core-impl/collections/aggregate/AggregateMeta.cpp (4 lines)
M			src/core-impl/collections/aggregate/AggregateQueryMaker.h (17 lines)
M			src/core-impl/collections/aggregate/AggregateQueryMaker.cpp (80 lines)
M			src/core-impl/collections/audiocd/AudioCdCollection.cpp (13 lines)
M			src/core-impl/collections/audiocd/AudioCdCollectionLocation.cpp (4 lines)
M			src/core-impl/collections/audiocd/FormatSelectionDialog.cpp (10 lines)
M			src/core-impl/collections/daap/DaapCollection.cpp (3 lines)
M			src/core-impl/collections/db/DatabaseCollection.cpp (8 lines)
M			src/core-impl/collections/db/MountPointManager.h (4 lines)
M			src/core-impl/collections/db/MountPointManager.cpp (8 lines)
M			src/core-impl/collections/db/sql/SqlCollection.cpp (14 lines)
M			src/core-impl/collections/db/sql/SqlCollectionLocation.cpp (21 lines)
M			src/core-impl/collections/db/sql/SqlMeta.cpp (2 lines)
M			src/core-impl/collections/db/sql/SqlQueryMaker.h (16 lines)
M			src/core-impl/collections/db/sql/SqlQueryMaker.cpp (48 lines)
M			src/core-impl/collections/db/sql/SqlQueryMakerInternal.h (14 lines)
M			src/core-impl/collections/db/sql/SqlQueryMakerInternal.cpp (28 lines)
M			src/core-impl/collections/db/sql/SqlRegistry.cpp (2 lines)
M			src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp (2 lines)
M			src/core-impl/collections/db/sql/mysqlcollection/MySqlCollectionFactory.cpp (3 lines)
M			src/core-impl/collections/ipodcollection/IpodCollection.h (8 lines)
M			src/core-impl/collections/ipodcollection/IpodCollection.cpp (68 lines)
M			src/core-impl/collections/ipodcollection/IpodCollectionFactory.cpp (22 lines)
M			src/core-impl/collections/ipodcollection/IpodCollectionLocation.cpp (12 lines)
M			src/core-impl/collections/ipodcollection/IpodMeta.cpp (2 lines)
M			src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.cpp (20 lines)
M			src/core-impl/collections/mediadevicecollection/MediaDeviceCollection.cpp (18 lines)
M			src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionLocation.cpp (10 lines)
M			src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.h (5 lines)
M			src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp (34 lines)
M			src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandlerCapability.cpp (2 lines)
M			src/core-impl/collections/mtpcollection/MtpCollection.cpp (2 lines)
M			src/core-impl/collections/mtpcollection/handler/MtpHandler.cpp (2 lines)
M			src/core-impl/collections/nepomukcollection/NepomukParser.h (9 lines)
M			src/core-impl/collections/nepomukcollection/NepomukQueryMaker.cpp (2 lines)
M			src/core-impl/collections/playdarcollection/PlaydarCollection.cpp (30 lines)
M			src/core-impl/collections/playdarcollection/PlaydarQueryMaker.h (14 lines)
M			src/core-impl/collections/playdarcollection/PlaydarQueryMaker.cpp (108 lines)
M			src/core-impl/collections/playdarcollection/support/Controller.cpp (11 lines)
M			src/core-impl/collections/playdarcollection/support/ProxyResolver.cpp (16 lines)
M			src/core-impl/collections/support/CollectionManager.h (2 lines)
M			src/core-impl/collections/support/CollectionManager.cpp (18 lines)
M			src/core-impl/collections/support/FileCollectionLocation.cpp (2 lines)
M			src/core-impl/collections/support/MemoryQueryMaker.cpp (18 lines)
M			src/core-impl/collections/support/MemoryQueryMakerInternal.h (20 lines)
M			src/core-impl/collections/support/MemoryQueryMakerInternal.cpp (43 lines)
M			src/core-impl/collections/support/TrashCollectionLocation.cpp (2 lines)
M			src/core-impl/collections/umscollection/UmsCollection.cpp (36 lines)
M			src/core-impl/collections/umscollection/UmsCollectionLocation.cpp (14 lines)
M			src/core-impl/collections/umscollection/podcasts/UmsPodcastProvider.cpp (9 lines)
M			src/core-impl/collections/upnpcollection/UpnpBrowseCollection.cpp (18 lines)
M			src/core-impl/collections/upnpcollection/UpnpCollectionBase.cpp (2 lines)
M			src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp (16 lines)
M			src/core-impl/collections/upnpcollection/UpnpQueryMaker.h (14 lines)
M			src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp (58 lines)
M			src/core-impl/collections/upnpcollection/UpnpQueryMakerInternal.h (8 lines)
M			src/core-impl/collections/upnpcollection/UpnpQueryMakerInternal.cpp (14 lines)
M			src/core-impl/logger/ProxyLogger.cpp (4 lines)
M			src/core-impl/meta/proxy/MetaProxy.cpp (8 lines)
M			src/core-impl/meta/proxy/MetaProxyWorker.cpp (16 lines)
M			src/core-impl/meta/timecode/TimecodeObserver.cpp (12 lines)
M			src/core-impl/playlists/types/file/PlaylistFileLoaderJob.cpp (4 lines)
M			src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.cpp (6 lines)
M			src/core-impl/podcasts/sql/PodcastSettingsDialog.cpp (34 lines)
M			src/core-impl/podcasts/sql/SqlPodcastProvider.cpp (88 lines)
M			src/core-impl/storage/StorageManager.cpp (8 lines)
M			src/core-impl/support/TrackLoader.cpp (23 lines)
M			src/core/collections/CollectionLocation.h (1 line)
M			src/core/collections/CollectionLocation.cpp (44 lines)
M			src/core/collections/MetaQueryMaker.cpp (37 lines)
M			src/core/collections/QueryMaker.h (16 lines)
M			src/core/collections/QueryMaker.cpp (4 lines)
M			src/core/collections/support/TrackForUrlWorker.cpp (6 lines)
M			src/core/podcasts/PodcastImageFetcher.h (4 lines)
M			src/core/podcasts/PodcastImageFetcher.cpp (2 lines)
M			src/core/podcasts/PodcastReader.cpp (18 lines)
M			src/core/transcoding/TranscodingController.cpp (4 lines)
M			src/covermanager/CoverFetcher.cpp (18 lines)
M			src/covermanager/CoverFetchingActions.h (4 lines)
M			src/covermanager/CoverFoundDialog.h (4 lines)
M			src/covermanager/CoverFoundDialog.cpp (62 lines)
M			src/covermanager/CoverManager.h (1 line)
M			src/covermanager/CoverManager.cpp (71 lines)
M			src/covermanager/CoverViewDialog.cpp (2 lines)
M			src/databaseimporter/SqlBatchImporter.cpp (9 lines)
M			src/dbus/DBusQueryHelper.cpp (6 lines)
M			src/dbus/mpris1/PlayerHandler.cpp (12 lines)
M			src/dbus/mpris1/TrackListHandler.cpp (4 lines)
M			src/dbus/mpris2/MediaPlayer2AmarokExtensions.cpp (4 lines)
M			src/dbus/mpris2/MediaPlayer2Player.cpp (56 lines)
M			src/dialogs/CollectionSetup.cpp (20 lines)
M			src/dialogs/DatabaseImporterDialog.cpp (20 lines)
M			src/dialogs/DiagnosticDialog.cpp (4 lines)
M			src/dialogs/EditFilterDialog.cpp (50 lines)
M			src/dialogs/EqualizerDialog.cpp (33 lines)
M			src/dialogs/MusicBrainzTagger.cpp (40 lines)
M			src/dialogs/OrganizeCollectionDialog.cpp (41 lines)
M			src/dialogs/TagDialog.h (14 lines)
M			src/dialogs/TagDialog.cpp (131 lines)
M			src/dialogs/TagGuesserDialog.cpp (44 lines)
M			src/dialogs/deletedialog.cpp (2 lines)
M			src/dialogs/deviceconfiguredialog.cpp (6 lines)
M			src/dynamic/Bias.cpp (24 lines)
M			src/dynamic/BiasFactory.cpp (6 lines)
M			src/dynamic/BiasSolver.cpp (16 lines)
M			src/dynamic/BiasedPlaylist.cpp (10 lines)
M			src/dynamic/biases/AlbumPlayBias.cpp (4 lines)
M			src/dynamic/biases/EchoNestBias.cpp (18 lines)
M			src/dynamic/biases/PartBias.cpp (18 lines)
M			src/dynamic/biases/QuizPlayBias.cpp (14 lines)
M			src/dynamic/biases/SearchQueryBias.cpp (12 lines)
M			src/dynamic/biases/TagMatchBias.cpp (18 lines)
M			src/importers/ImporterManager.cpp (8 lines)
M			src/importers/amarok/AmarokEmbeddedSqlConnection.cpp (2 lines)
M			src/mac/GrowlInterface.cpp (4 lines)
M			src/mac/MacSystemNotify.mm (4 lines)
M			src/main.cpp (4 lines)
M			src/moodbar/MoodbarManager.cpp (2 lines)
M			src/musicbrainz/MusicBrainzFinder.cpp (26 lines)
M			src/musicbrainz/MusicBrainzTagsView.cpp (10 lines)
M			src/musicbrainz/MusicDNSFinder.cpp (32 lines)
M			src/network/NetworkAccessManagerProxy.h (6 lines)
M			src/network/NetworkAccessManagerProxy.cpp (13 lines)
M			src/network/NetworkAccessViewer.cpp (10 lines)
M			src/playback/DelayedDoers.cpp (9 lines)
M			src/playback/EqualizerController.h (4 lines)
M			src/playback/EqualizerController.cpp (6 lines)
M			src/playback/Fadeouter.cpp (6 lines)
M			src/playback/PowerManager.cpp (12 lines)
M			src/playlist/PlaylistActions.cpp (10 lines)
M			src/playlist/PlaylistBreadcrumbItem.cpp (8 lines)
M			src/playlist/PlaylistController.cpp (20 lines)
M			src/playlist/PlaylistDock.h (2 lines)
M			src/playlist/PlaylistDock.cpp (74 lines)
M			src/playlist/PlaylistInfoWidget.cpp (22 lines)
M			src/playlist/PlaylistModel.cpp (28 lines)
M			src/playlist/PlaylistQueueEditor.cpp (12 lines)
M			src/playlist/PlaylistSortWidget.h (7 lines)
M			src/playlist/PlaylistSortWidget.cpp (22 lines)
M			src/playlist/ProgressiveSearchWidget.cpp (34 lines)
M			src/playlist/layouts/LayoutConfigAction.cpp (10 lines)
M			src/playlist/layouts/LayoutEditDialog.cpp (10 lines)
M			src/playlist/layouts/PlaylistLayoutEditDialog.cpp (32 lines)
M			src/playlist/navigators/DynamicTrackNavigator.cpp (19 lines)
M			src/playlist/navigators/NavigatorConfigAction.cpp (6 lines)
M			src/playlist/navigators/NonlinearTrackNavigator.cpp (10 lines)
M			src/playlist/navigators/RepeatTrackNavigator.cpp (4 lines)
M			src/playlist/navigators/TrackNavigator.cpp (7 lines)
M			src/playlist/proxymodels/GroupingProxy.cpp (10 lines)
M			src/playlist/view/PlaylistViewCommon.cpp (43 lines)
M			src/playlist/view/listview/InlineEditorWidget.cpp (7 lines)
M			src/playlist/view/listview/PrettyItemDelegate.cpp (8 lines)
M			src/playlist/view/listview/PrettyListView.h (2 lines)
M			src/playlist/view/listview/PrettyListView.cpp (36 lines)
M			src/playlist/view/listview/SourceSelectionPopup.cpp (4 lines)
M			src/playlistgenerator/ConstraintGroup.cpp (4 lines)
M			src/playlistgenerator/ConstraintSolver.cpp (12 lines)
M			src/playlistgenerator/Preset.cpp (4 lines)
M			src/playlistgenerator/PresetEditDialog.cpp (17 lines)
M			src/playlistgenerator/PresetModel.h (2 lines)
M			src/playlistgenerator/PresetModel.cpp (9 lines)
M			src/playlistgenerator/constraints/Checkpoint.cpp (6 lines)
M			src/playlistgenerator/constraints/PlaylistDuration.cpp (6 lines)
M			src/playlistgenerator/constraints/PlaylistFileSize.cpp (8 lines)
M			src/playlistgenerator/constraints/PlaylistLength.cpp (6 lines)
M			src/playlistgenerator/constraints/PreventDuplicates.cpp (2 lines)
M			src/playlistgenerator/constraints/TagMatch.cpp (13 lines)
M			src/playlistmanager/PlaylistManager.cpp (13 lines)
M			src/playlistmanager/file/PlaylistFileProvider.cpp (6 lines)
M			src/scanner/AbstractDirectoryWatcher.cpp (14 lines)
M			src/scanner/AbstractScanResultProcessor.cpp (17 lines)
M			src/scanner/GenericScanManager.cpp (18 lines)
M			src/scanner/GenericScannerJob.cpp (8 lines)
M			src/scripting/scriptconsole/ScriptConsole.cpp (29 lines)
M			src/scripting/scriptengine/AmarokCollectionViewScript.cpp (5 lines)
M			src/scripting/scriptengine/AmarokEngineScript.cpp (26 lines)
M			src/scripting/scriptengine/AmarokEqualizerScript.cpp (8 lines)
M			src/scripting/scriptengine/AmarokLyricsScript.cpp (4 lines)
M			src/scripting/scriptengine/AmarokNetworkScript.cpp (4 lines)
M			src/scripting/scriptengine/ScriptingDefines.cpp (2 lines)
M			src/scripting/scriptengine/exporters/MetaTypeExporter.cpp (2 lines)
M			src/scripting/scriptengine/exporters/QueryMakerExporter.cpp (8 lines)
M			src/scripting/scriptengine/exporters/ScriptableBiasExporter.cpp (2 lines)
M			src/scripting/scriptmanager/ScriptItem.cpp (14 lines)
M			src/scripting/scriptmanager/ScriptManager.cpp (12 lines)
M			src/scripting/scriptmanager/ScriptUpdater.cpp (6 lines)
M			src/services/ServiceSqlQueryMaker.cpp (22 lines)
M			src/services/ServiceSqlRegistry.cpp (2 lines)
M			src/services/scriptable/ScriptableServiceQueryMaker.cpp (27 lines)
M			src/statsyncing/Controller.h (2 lines)
M			src/statsyncing/Controller.cpp (58 lines)
M			src/statsyncing/Process.cpp (36 lines)
M			src/statsyncing/collection/CollectionProvider.h (4 lines)
M			src/statsyncing/collection/CollectionProvider.cpp (22 lines)
M			src/statsyncing/jobs/SynchronizeTracksJob.cpp (18 lines)
M			src/statsyncing/models/ProvidersModel.cpp (4 lines)
M			src/statsyncing/ui/ChooseProvidersPage.cpp (14 lines)
M			src/statsyncing/ui/ConfigureProviderDialog.cpp (2 lines)
M			src/statsyncing/ui/CreateProviderDialog.cpp (6 lines)
M			src/statsyncing/ui/MatchedTracksPage.cpp (53 lines)
M			src/statusbar/CompoundProgressBar.cpp (16 lines)
M			src/statusbar/KJobProgressBar.cpp (6 lines)
M			src/statusbar/LongMessageWidget.cpp (2 lines)
M			src/statusbar/NetworkProgressBar.cpp (11 lines)
M			src/statusbar/ProgressBar.h (16 lines)
M			src/statusbar/ProgressBar.cpp (5 lines)
M			src/synchronization/SynchronizationBaseJob.h (6 lines)
M			src/synchronization/SynchronizationBaseJob.cpp (28 lines)
M			src/toolbar/CurrentTrackToolbar.cpp (4 lines)
M			src/toolbar/MainToolbar.cpp (110 lines)
M			src/toolbar/VolumePopupButton.cpp (14 lines)
M			src/transcoding/TranscodingAssistantDialog.cpp (20 lines)
M			src/transcoding/TranscodingJob.h (7 lines)
M			src/transcoding/TranscodingJob.cpp (16 lines)
M			src/transcoding/TranscodingPropertySliderWidget.cpp (4 lines)
M			src/widgets/AlbumBreadcrumbWidget.h (4 lines)
M			src/widgets/AlbumBreadcrumbWidget.cpp (8 lines)
M			src/widgets/AmarokDockWidget.cpp (2 lines)
M			src/widgets/AnimatedLabelStack.cpp (2 lines)
M			src/widgets/BreadcrumbItemButton.cpp (4 lines)
M			src/widgets/FilenameLayoutWidget.cpp (46 lines)
M			src/widgets/IconButton.cpp (2 lines)
M			src/widgets/MetaQueryWidget.h (15 lines)
M			src/widgets/MetaQueryWidget.cpp (74 lines)
M			src/widgets/Osd.cpp (32 lines)
M			src/widgets/PlayPauseButton.cpp (2 lines)
M			src/widgets/PrettyTreeView.h (2 lines)
M			src/widgets/PrettyTreeView.cpp (2 lines)
M			src/widgets/ProgressWidget.h (2 lines)
M			src/widgets/ProgressWidget.cpp (42 lines)
M			src/widgets/SearchWidget.h (1 line)
M			src/widgets/SearchWidget.cpp (25 lines)
M			src/widgets/SliderWidget.cpp (6 lines)
M			src/widgets/TokenDropTarget.h (3 lines)
M			src/widgets/TokenDropTarget.cpp (10 lines)
M			src/widgets/TokenWithLayout.cpp (2 lines)
M			src/widgets/TrackActionButton.cpp (10 lines)
M			src/widgets/TrackSelectWidget.cpp (4 lines)
M			src/widgets/VolumeDial.cpp (6 lines)
M			src/widgets/kdatecombo.h (3 lines)
M			src/widgets/kdatecombo.cpp (12 lines)
M			tests/core-impl/collections/aggregate/TestAggregateMeta.cpp (2 lines)
M			tests/core-impl/collections/db/sql/TestSqlCollection.cpp (8 lines)
M			tests/core-impl/collections/db/sql/TestSqlQueryMaker.cpp (100 lines)
M			tests/core-impl/collections/db/sql/TestSqlScanManager.cpp (14 lines)
M			tests/core-impl/collections/db/sql/TestSqlTrack.cpp (4 lines)
M			tests/core-impl/collections/support/TestMemoryQueryMaker.cpp (8 lines)
M			tests/core-impl/meta/multi/TestMetaMultiTrack.cpp (2 lines)
M			tests/core-impl/support/TestTrackLoader.cpp (10 lines)
M			tests/core/collections/TestQueryMaker.cpp (4 lines)
M			tests/core/collections/support/TestTrackForUrlWorker.cpp (15 lines)
M			tests/core/meta/TestMetaTrack.cpp (2 lines)
M			tests/core/playlists/TestPlaylistObserver.cpp (26 lines)
M			tests/dynamic/TestDynamicModel.cpp (8 lines)
M			tests/importers/TestImporterProvider.cpp (4 lines)
M			tests/mocks/MockTrackForUrlWorker.cpp (6 lines)
M			tests/qt-modeltest/modeltest.cpp (56 lines)
M			tests/scanner/TestGenericScanManager.cpp (14 lines)
M			utilities/collectionscanner/CollectionScanner.cpp (2 lines)

Commit	Tree	Parents	Author	Summary	Date
3a6734458ce2	527287762e33	52bd757b83e1	Maldela	Ported much of the Code to new signal/slot syntax.	Mar 27 2017, 7:04 PM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	20431	52bd757		Oct 7 2017, 11:08 AM	★	★

Port to new signal/slot syntaxClosedPublicActions

Details

Diff Detail

Large Diff

Revision ContentsChangeset List

Diff 20431

src/ActionClasses.cpp

src/AmarokMimeData.cpp

src/AmarokProcess.cpp

src/App.h

src/App.cpp

src/EngineController.h

src/EngineController.cpp

src/KNotificationBackend.cpp

src/MainWindow.cpp

src/MediaDeviceCache.cpp

src/MediaDeviceMonitor.cpp

src/OpmlParser.cpp

src/SvgHandler.cpp

src/TrayIcon.h

src/TrayIcon.cpp

src/aboutdialog/ExtendedAboutDialog.h

src/aboutdialog/ExtendedAboutDialog.cpp

src/aboutdialog/OcsPersonItem.cpp

src/aboutdialog/OcsPersonListWidget.cpp

src/aboutdialog/libattica-ocsclient/CMakeLists.txt

src/aboutdialog/libattica-ocsclient/activitylistjob.cpp

src/aboutdialog/libattica-ocsclient/categorylistjob.cpp

src/aboutdialog/libattica-ocsclient/contentjob.cpp

src/aboutdialog/libattica-ocsclient/contentlistjob.cpp

src/aboutdialog/libattica-ocsclient/eventjob.cpp

src/aboutdialog/libattica-ocsclient/eventlistjob.cpp

src/aboutdialog/libattica-ocsclient/folderlistjob.cpp

src/aboutdialog/libattica-ocsclient/knowledgebasejob.cpp

src/aboutdialog/libattica-ocsclient/knowledgebaselistjob.cpp

src/aboutdialog/libattica-ocsclient/messagelistjob.cpp

src/aboutdialog/libattica-ocsclient/personjob.cpp

src/aboutdialog/libattica-ocsclient/personlistjob.cpp

src/aboutdialog/libattica-ocsclient/postjob.cpp

src/aboutdialog/libattica-ocsclient/providerinitjob.cpp

src/amarokurls/AmarokUrlAction.cpp

src/amarokurls/BookmarkCurrentButton.cpp

src/amarokurls/BookmarkManagerWidget.cpp

src/amarokurls/BookmarkMetaActions.cpp

src/amarokurls/BookmarkTreeView.h

src/amarokurls/BookmarkTreeView.cpp

src/browsers/BrowserBreadcrumbItem.cpp

src/browsers/BrowserBreadcrumbWidget.cpp

src/browsers/BrowserCategory.cpp

src/browsers/BrowserCategoryList.cpp

src/browsers/BrowserDock.cpp

src/browsers/BrowserMessageArea.h

src/browsers/BrowserMessageArea.cpp

src/browsers/CollectionTreeItem.cpp

src/browsers/CollectionTreeItemModel.cpp

src/browsers/CollectionTreeItemModelBase.h

src/browsers/CollectionTreeItemModelBase.cpp

src/browsers/CollectionTreeView.h

src/browsers/CollectionTreeView.cpp

src/browsers/SingleCollectionTreeItemModel.cpp

src/browsers/collectionbrowser/CollectionWidget.cpp

src/browsers/filebrowser/FileBrowser.h

src/browsers/filebrowser/FileBrowser.cpp

src/browsers/filebrowser/FileBrowser_p.h

src/browsers/filebrowser/FileView.h

src/browsers/filebrowser/FileView.cpp

src/browsers/playlistbrowser/APGCategory.cpp

src/browsers/playlistbrowser/DynamicBiasDialog.cpp

src/browsers/playlistbrowser/DynamicCategory.cpp

src/browsers/playlistbrowser/DynamicView.cpp

src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp

src/browsers/playlistbrowser/PlaylistBrowserModel.cpp

src/browsers/playlistbrowser/PlaylistBrowserView.cpp

src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp

src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp

src/browsers/playlistbrowser/PodcastCategory.cpp

src/browsers/playlistbrowser/QtGroupingProxy.cpp

src/browsers/servicebrowser/ServiceBrowser.cpp

src/configdialog/ConfigDialog.cpp

src/configdialog/dialogs/CollectionConfig.cpp

Port to new signal/slot syntax
ClosedPublic
Actions

Revision Contents
Changeset List